[RFC] Deprecate curl_share_close() (#19452)

DanielEScherzer · web-flow · commit 699e5632b1c1 · 2025-08-12T05:49:52.000-07:00
https://wiki.php.net/rfc/deprecations_php_8_5
diff --git a/ext/curl/curl.stub.php b/ext/curl/curl.stub.php
@@ -3811,6 +3811,7 @@ function curl_setopt_array(CurlHandle $handle, array $options): bool {}
 
 function curl_setopt(CurlHandle $handle, int $option, mixed $value): bool {}
 
+#[\Deprecated(since: '8.5', message: "as it has no effect since PHP 8.0")]
 function curl_share_close(CurlShareHandle $share_handle): void {}
 
 function curl_share_errno(CurlShareHandle $share_handle): int {}
diff --git a/ext/curl/curl_arginfo.h b/ext/curl/curl_arginfo.h
diff --git a/ext/curl/tests/curl_share_close_basic001.phpt b/ext/curl/tests/curl_share_close_basic001.phpt
@@ -13,8 +13,10 @@ curl_share_close($sh);
 var_dump($sh);
 
 ?>
---EXPECT--
+--EXPECTF--
 object(CurlShareHandle)#1 (0) {
 }
+
+Deprecated: Function curl_share_close() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
 object(CurlShareHandle)#1 (0) {
 }

Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,10 @@ curl_share_close($sh);`
`13`	`13`	`var_dump($sh);`
`14`	`14`
`15`	`15`	`?>`
`16`		`---EXPECT--`
	`16`	`+--EXPECTF--`
`17`	`17`	`object(CurlShareHandle)#1 (0) {`
`18`	`18`	`}`
	`19`	`+`
	`20`	`+Deprecated: Function curl_share_close() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d`
`19`	`21`	`object(CurlShareHandle)#1 (0) {`
`20`	`22`	`}`