Remove compile-time HANDLE_NUMERIC (see bug #63217)

hikari-no-yume · hikari-no-yume · commit 3f622077c32f · 2016-03-25T16:32:12.000Z
diff --git a/Zend/tests/list_keyed_ArrayAccess.phpt b/Zend/tests/list_keyed_ArrayAccess.phpt
@@ -10,7 +10,31 @@ $antonymObject["happy"] = "sad";
 list("good" => $good, "happy" => $happy) = $antonymObject;
 var_dump($good, $happy);
 
+echo PHP_EOL;
+
+class IndexPrinter implements ArrayAccess
+{
+    public function offsetGet($offset) {
+        echo "GET ";
+        var_dump($offset);
+    }
+    public function offsetSet($offset, $value) {
+    }
+    public function offsetExists($offset) {
+    }
+    public function offsetUnset($offset) {
+    }
+}
+
+$op = new IndexPrinter;
+list(123 => $x) = $op;
+// PHP shouldn't convert this to an integer offset, because it's ArrayAccess
+list("123" => $x) = $op;
+
 ?>
 --EXPECT--
 string(3) "bad"
 string(3) "sad"
+
+GET int(123)
+GET string(3) "123"
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
@@ -2751,7 +2751,6 @@ static void zend_compile_keyed_list_assign(zend_ast_list *list, znode *expr_node
 		znode fetch_result, dim_node;
 
 		zend_compile_expr(&dim_node, key_ast);
-		zend_handle_numeric_op(&dim_node);
 
 		if (expr_node->op_type == IS_CONST) {
 			Z_TRY_ADDREF(expr_node->u.constant);
