Drop \n when highlighting (#79)

TimWolla · web-flow · commit 01d6beb366bf · 2023-08-10T14:18:15.000+02:00
* Drop `\n` when highlighting Actual newlines will be replaced by `<br />` during highlighting and the `\n` in the boilerplate conflicts with `white-space: pre;`. see php/doc-en#2648 * Simplify character replacement for `highlight_string` result
diff --git a/phpdotnet/phd/Highlighter.php b/phpdotnet/phd/Highlighter.php
@@ -63,7 +63,10 @@ public function highlight($text, $role, $format)
 
         if ($role == 'php') {
             try {
-                return str_replace('&nbsp;', ' ', highlight_string($text, 1));
+                return strtr(highlight_string($text, 1), [
+                    '&nbsp;' => ' ',
+                    "\n" => '',
+                ]);
             } catch (\ParseException $e) {
                 v("Parse error while highlighting PHP code: %s\nText: %s", (string) $e, $text, E_USER_WARNING);
 
