Conversation
Contributor
Author
|
I think the tests are failing because of the same reason I was unable to do the build locally. I had to run my builds with an explicit version v2.10.2 |
dunglas
requested changes
Feb 21, 2026
caddy/mercure-route.go
Outdated
| @@ -0,0 +1,47 @@ | |||
| //go:build !nomercure | |||
Member
There was a problem hiding this comment.
The file name should be mercureroot.go, but I would just go for mercure.go
Contributor
Author
There was a problem hiding this comment.
Happy to do that, but there's already a mercure.go and mercure-skip.go
Wanna put these in the same file?
henderkes
reviewed
Feb 21, 2026
caddy/mercure-route-skip.go
Outdated
| @@ -0,0 +1,10 @@ | |||
| //go:build nomercure | |||
Contributor
There was a problem hiding this comment.
this one also just mercure-skip or nomercure.go
tehmaestro
force-pushed
the
nomercure-fix
branch
from
74bd15b to
5b5b30a
Compare
Contributor
Author
|
Co-authored-by: Alexander Stecher <[email protected]> Signed-off-by: tehmaestro <[email protected]>
henderkes
reviewed
Feb 22, 2026
dunglas
approved these changes
Feb 22, 2026
henderkes
approved these changes
Feb 22, 2026
Member
|
Thanks! |
johanjanssens
pushed a commit
to johanjanssens/frankenphp
that referenced
this pull request
Feb 26, 2026
- Fixes nomercure tag build - Conditionally addds the mercure route and mercure project import Fixes php#2209 I am by no means a go developer, feel free to use this or not :) --------- Signed-off-by: tehmaestro <[email protected]> Co-authored-by: Alexander Stecher <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2209
I am by no means a go developer, feel free to use this or not :)