fix: added missing decrement for the "ready" WaitGroup counter#1890
Merged
withinboredom merged 1 commit intophp:mainfrom Sep 22, 2025
Merged
fix: added missing decrement for the "ready" WaitGroup counter#1890withinboredom merged 1 commit intophp:mainfrom
withinboredom merged 1 commit intophp:mainfrom
Conversation
Member
|
Thanks! This looks interesting! Generally, it is a good idea to use the description to explain your intention of the PR as well as add a test for it so we don’t accidentally regress in the future. |
AlliBalliBaba
approved these changes
Sep 22, 2025
Contributor
|
Yeah this a rare race condition if workers restart and shutdown at the same time. Feel free to refactor anything you think is not idiomatic in this or a separate PR 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
missing
ready.Done()decrement beforecontinuestatement in theforloop preventsready.Wait()to release and leads to a deadlock