Conversation
…context # Conflicts: # context.go
dunglas
requested changes
Aug 21, 2025
context.go
Outdated
| } | ||
|
|
||
| fc.rejectBadRequest("Invalid request path") | ||
| // TODO: Caddy already does this, probably unnecessary |
Member
There was a problem hiding this comment.
This may be useful for users of the standalone Go lib.
Contributor
Author
There was a problem hiding this comment.
Hmm yeah, we can leave it if you want. Alternative would be to just use request.ContentLength and set it to 0 if negative.
Contributor
Author
|
Not sure how the pipeline got cancelled, but it's actually green. |
dunglas
approved these changes
Aug 25, 2025
Member
|
Thanks! |
henderkes
pushed a commit
to static-php/frankenphp
that referenced
this pull request
Sep 11, 2025
* Removes NewRequestWithContext. * Moves cgi logic to cgi.go * Calls 'update_request_info' from the C side. * Calls 'update_request_info' from the C side. * clang-format * Removes unnecessary export. * Adds TODO. * Adds TODO. * Removes 'is_worker_thread' * Shortens return statement. * Removes the context refactor. * adjusts comment. * Skips parsing cgi path variables on explicitly assigned worker. * suggesions by @dunglas. * Re-introduces 'is_worker_thread'. * More formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a small refactor of how the server and request contexts are handled, it
c -> go -> ccall when updating the request contextI hope to detangle thread logic from cgi logic in order to make it possible in the future to provide different kinds of threads, like task workers (for parallelism/extensions) or async threads (when/if PHP supports native async).