Conversation
withinboredom
commented
May 31, 2025
Comment on lines
+495
to
+498
| if fc == nil { | ||
| return C.bool(false) | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
Apparently PHP calls flush() before the request context is setup. So, this handles that case.
Contributor
There was a problem hiding this comment.
I've also noticed before that a call to flush() can happen outside of requests. Do you maybe know when exactly PHP does this? If so, would be nice to add a comment
Member
Author
There was a problem hiding this comment.
I don’t know if a comment would be useful, but PHP flushes:
- when
flush()is called, - when a line is finished being output from
system() - when implicit flush is turned on, at the end of each
echo,print, or before each php open-tag statement - during module shutdown (this is probably the one that triggered this)
dunglas
reviewed
May 31, 2025
Co-authored-by: Kévin Dunglas <[email protected]>
Member
|
Thank you very much! |
henderkes
pushed a commit
to mhpcc/frankenphp
that referenced
this pull request
Jun 5, 2025
* add tests * fix test * attempt to send headers when flushing * Update testdata/only-headers.php Co-authored-by: Kévin Dunglas <[email protected]> --------- Co-authored-by: Kévin Dunglas <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was reported in #1620 and looking at how this was fixed in php/php-src#12385, I basically just recreated it here.