get package tag version from binary instead#1606
Conversation
henderkes
force-pushed
the
fix-package-version
branch
from
1730e07 to
d2dd016
Compare
| fi | ||
| fi | ||
| version_output="$(dist/"$bin" version)" | ||
| frankenphp_version=$(echo "$version_output" | grep -oP 'FrankenPHP\s+\K[^ ]+' || true) |
There was a problem hiding this comment.
our scripts use capitalized variables. Any reason you are deviating here?
There was a problem hiding this comment.
meant to signify a non-exported variable that also isn't read from the command line. I essentially wanted to avoid people thinking the FRANKENPHP_VERSION variable would influence it. Can give it a different all uppercase name!
There was a problem hiding this comment.
(should probably change all the other variables in the script and all our other scripts then, too, because so far we seem to use lowercase names for all "private" variables)
|
Thanks |
|
It looks like it still doesn't work: https://github.com/dunglas/frankenphp/releases/tag/v1.7.0 |
* get package tag version from binary instead * capture output for better debugging instead
3 participants
#1605