fix: duplicate metrics collector registration attempted panic#1392
Conversation
Member
|
I tried to replicate the issue with FrankenPHP but I didn't manage to do it. For some reason, only Mercure (which is is shipped with FrankenPHP) seems affected. Maybe should we merge this PR by security anyway. |
Contributor
Author
|
i also didn't manage to replicate the issue with |
withinboredom
approved these changes
Feb 19, 2025
Member
|
Thanks @IndraGunawan. I'm not fond of merging "just in case", but I have the feeling that the crash may happen in special conditions. Maybe @mohammed90 has an idea of how to add a test for that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1388.
Similar to dunglas/mercure#1013 and caddyserver/caddy#6820.