use trimQuotes() for trimming quotes#2
Merged
photra merged 1 commit intophotra:3630-add-env-quotes-handlingfrom Jun 10, 2022
Merged
Conversation
This makes sure that only the outer-most quotes are trimmed, and that quotes are only trimmed if equal (start/end). Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
3630_add_env_quotes_handling_suggestions
branch
from
3edb416 to
dd330e1
Compare
Owner
|
I didn't know we have that function 😮 I took a look at it and noticed a potential panic as well, but it looks like you have already addressed it in another PR. Merging this now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that only the outer-most quotes are trimmed, and
that quotes are only trimmed if equal (start/end).
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)