don't enumerate a struct with Map.new in diff.ex#3970
Closed
zachdaniel wants to merge 1 commit intophoenixframework:mainfrom
Closed
don't enumerate a struct with Map.new in diff.ex#3970zachdaniel wants to merge 1 commit intophoenixframework:mainfrom
Map.new in diff.ex#3970zachdaniel wants to merge 1 commit intophoenixframework:mainfrom
Conversation
zachdaniel
commented
Aug 31, 2025
| resolve_templates(Map.put(rendered, @static, Map.fetch!(template, static)), template) | ||
| end | ||
|
|
||
| defp resolve_templates(%struct{} = rendered, template) do |
Contributor
Author
There was a problem hiding this comment.
I'm not sure how structs were really meant to be handled here, but this seemed reasonable with limited knowledge.
Collaborator
There was a problem hiding this comment.
Can you show the template where this happens?
Contributor
Author
There was a problem hiding this comment.
The stack trace didn't contain the line number or file so it took a while to track it down, sorry 😆.
It is in our app.html.heex, which looks roughly like this:
<div class="flex h-screen bg-white">
<%= if assigns[:current_user] do %>
<MyAppWeb.Components.Sidebar.component
id="sidebar"
current_user={@current_user}
/>
<div class="flex-1 ml-64 max-w-[calc(100%-16rem)]">
<header class="bg-white shadow-xs">
<div class="px-4 sm:px-6 lg:px-8 py-4">
<div class="flex items-center justify-between">
<h1 class="text-xl font-semibold text-gray-900">
{assigns[:page_title] || "Page title"}
</h1>
<div class="flex items-center">
<%= if assigns[:current_user] do %>
<span class="text-sm text-gray-700 mr-4">{@current_user.email}</span>
<.link href={~p"/sign-out"} class="text-sm text-gray-700 hover:text-gray-900">
Sign out
</.link>
<% else %>
<.link href={~p"/sign-in"} class="text-sm text-gray-700 hover:text-gray-900">
Sign in
</.link>
<% end %>
</div>
</div>
</div>
</header>
<main class="px-4 py-8 sm:px-6 lg:px-8">
<.flash_group flash={@flash} />
{@inner_content}
</main>
</div>
<% else %>
<div class="flex-1">
<main class="px-4 py-8 sm:px-6 lg:px-8">
<.flash_group flash={@flash} />
{@inner_content}
</main>
</div>
<% end %>
</div>The problematic area is here:
<span class="text-sm text-gray-700 mr-4">{@current_user.email}</span>in Ash case insensitive strings have their type retained with a struct, i.e %Ash.CiString{value: "email"}, and that is the struct that gets matched in my example.
Contributor
Author
There was a problem hiding this comment.
that struct implements to String.Chars protocol which is what I believe is being used to display the value
SteffenDE
added a commit
that referenced
this pull request
Sep 2, 2025
SteffenDE
added a commit
that referenced
this pull request
Sep 2, 2025
SteffenDE
added a commit
that referenced
this pull request
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves an issue encountered while upgrading to 1.1
The stack traces shows
1.2.0-devbecause I cloned it locally while testing, but the error is present in prior versions.