Fix warning when importing phoenix_live_view#3926
Merged
SteffenDE merged 1 commit intophoenixframework:mainfrom Aug 1, 2025
Merged
Fix warning when importing phoenix_live_view#3926SteffenDE merged 1 commit intophoenixframework:mainfrom
phoenix_live_view#3926SteffenDE merged 1 commit intophoenixframework:mainfrom
Conversation
This fixes the following warning that is encountered when trying to
import `phoenix_live_view`:
```
▲ [WARNING] The condition "types" here will never be used as it comes after "default" [package.json]
../deps/phoenix_live_view/package.json:14:6:
14 │ "types": "./assets/js/types/index.d.ts"
╵ ~~~~~~~
The "default" condition comes earlier and will always be chosen:
../deps/phoenix_live_view/package.json:13:6:
13 │ "default": "./priv/static/phoenix_live_view.esm.js",
╵ ~~~~~~~~~
```
Contributor
|
Thanks for this! (I introduced the original change in #3915.) I would never have suspected these were ordered, and figured it made sense for |
Collaborator
|
🙌🏻 |
SteffenDE
pushed a commit
that referenced
this pull request
Aug 5, 2025
This fixes the following warning that is encountered when trying to
import `phoenix_live_view`:
```
▲ [WARNING] The condition "types" here will never be used as it comes after "default" [package.json]
../deps/phoenix_live_view/package.json:14:6:
14 │ "types": "./assets/js/types/index.d.ts"
╵ ~~~~~~~
The "default" condition comes earlier and will always be chosen:
../deps/phoenix_live_view/package.json:13:6:
13 │ "default": "./priv/static/phoenix_live_view.esm.js",
╵ ~~~~~~~~~
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following warning that is encountered when trying to import
phoenix_live_view:Fixes #3925