Skip to content

fix variable tainting#3856

Merged
SteffenDE merged 1 commit intomainfrom
sd-fix-analyze
Jun 20, 2025
Merged

fix variable tainting#3856
SteffenDE merged 1 commit intomainfrom
sd-fix-analyze

Conversation

@SteffenDE
Copy link
Collaborator

Relates to: https://github.com/phoenixframework/phoenix_live_view/pull/3837/files

We've been missing an analyze call which would for example cause

<.form :let={f} for={@changeset}>
  {f[:field].value}
</.form>

to not re-render when changeset is changed.

Relates to: https://github.com/phoenixframework/phoenix_live_view/pull/3837/files

We've been missing an analyze call which would for example cause

```heex
<.form :let={f} for={@Changeset}>
  {f[:field].value}
</.form>
```

to not re-render when changeset is changed.
@SteffenDE SteffenDE requested a review from josevalim June 20, 2025 12:16
@SteffenDE SteffenDE merged commit 566e10e into main Jun 20, 2025
14 checks passed
@SteffenDE SteffenDE deleted the sd-fix-analyze branch June 20, 2025 12:24
SteffenDE added a commit that referenced this pull request Jun 20, 2025
Relates to: https://github.com/phoenixframework/phoenix_live_view/pull/3837/files

We've been missing an analyze call which would for example cause

```heex
<.form :let={f} for={@Changeset}>
  {f[:field].value}
</.form>
```

to not re-render when changeset is changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments