Repository navigation
Conversation
nallwhy
changed the title
:haltmount/3 of LiveView when the instruction of mounted hooks is :halt
nallwhy
changed the title
mount/3 of LiveView when the instruction of mounted hooks is :haltmount/3 of LiveView when the returned instruction of hooks on mount is :halt
nallwhy
changed the title
mount/3 of LiveView when the returned instruction of hooks on mount is :haltmount/3 of LiveView when the instruction of returns of hooks on mount is :halt
Member
|
@nallwhy Looks good! There is already a test for redirect on mount, but we can update it to ensure the mount callback is not invoked on the LiveView. In the test support lifecycle module, look for # Phoenix.LiveViewTest.HooksLive.RedirectMount
def mount(_, _, socket) do
case socket.assigns.live_action do
:halt -> raise "mount should not have been called"
_ -> {:ok, socket}
end
endthen once the tests are passing we can |
Member
|
I am working on another fix too, so I went ahead and merged this with the test changes, thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes #1598.
If you agree with this approach, I will keep work on it.
TODO