Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: phoenix-tui/phoenix
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.1.0
Choose a base ref
...
head repository: phoenix-tui/phoenix
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.1.1
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Dec 3, 2025

  1. fix(tea): CancelableReader for ExecProcess stdin release (v0.1.1) (#10)

    * fix(tea): add CancelableReader for ExecProcess stdin release
    
    Add CancelableReader wrapper to unblock Read() on Cancel().
    This fixes stdin conflict when ExecProcess runs without alt screen.
    
    - CancelableReader uses background goroutine + channel pattern
    - Reader.Cancel() immediately unblocks pending reads
    - stopInputReader() now calls Cancel() before context cancellation
    - startInputReader() creates new Reader after Cancel (not reusable)
    
    * fix(tea): clear cancel/done in inputReader defer for clean state
    
    When inputReader goroutine exits on its own (EOF from terminal),
    the defer block now properly nils out inputReaderCancel and
    inputReaderDone to match the cleaned-up state.
    
    This fixes TestProgram_ExecProcess_NoInputReaderLeak failure on macOS
    where the test expected nil values after natural goroutine exit.
    kolkov authored Dec 3, 2025
    Configuration menu
    Copy the full SHA
    4381275 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8f1912c View commit details
    Browse the repository at this point in the history
Loading