Skip to content

Conversation

@phausamann
Copy link
Owner

No description provided.

jaicher and others added 30 commits February 24, 2020 14:34
* Added test for GH3748

* Rename newly created index in swap_dims() to dim name if not multiindex

Fixes GH3748

* Updated whats-new.rst with pull request information for swap_dims fix

* Move tests for GH3748 into existing swap_dims tests

+ integrated new tests for GH3748 for DataArray into existing swap_dims
  tests
+ added similar tests for Dataset
+ added test for multiindex case

Co-authored-by: Deepak Cherian <[email protected]>
* don't try to wrap datetime objects in pint

* make sure we actually decide based on dask.array.Array

* update whats-new.rst

* directly use isnat

* always use numpy's isnat
* Initial progress on implementing cftime floor/ceil/round

* Improve tests and docstrings

* Add tests of rounding cftime datetimes via dt accessor

* Add documentation

* docstring edits

* Test rounding raises error with non-fixed frequency

* black

* typo

* A couple cleanup items:
  - Fix floating point issue in asi8 and add tests
  - Ensure dask only computes once when using the rounding accessors

* black
* bug fixed and added zarr group tests

* black .

* added info to whats-new

Co-authored-by: Ryan Abernathey <[email protected]>
* Turn on html repr by default

* Add By line to release docs

* Change tests to expect html as the default display_style
* Add test of DataWithCoords.coarsen() for #3376

* Add test of Variable.coarsen() for #3376

* Add keep_attrs kwarg to DataWithCoords.coarsen() for #3376

* Style and spelling fixes (#3376)

* Fix test_coarsen_keep_attrs by removing self from input

* Pass keep_attrs through to _coarsen_cls and _rolling_cls returns (#3376)

* Move keyword from coarsen to mean in test_coarsen_keep_attrs

* Start handling keep_attrs in rolling class constructors (#3376)

* Update Coarsen constructor and DatasetCoarsen class method (GH3376)

Assign keep_attrs keyword value to Coarsen objects in constructor
Add conditional inside _reduce_method.wrapped_func branching on self.keep_attrs and pass back to returned Dataset

* Incorporate code review from @max-sixty

* Fix Dataset.coarsen and Variable.coarsen for GH3376

Handle global keep_attrs setting inside Variable._coarsen_reshape

Pass attrs through consistently inside DatasetCoarsen._reduce_method

Don't pass Variable.coarsen a keyword argument it doesn't expect inside DataArrayCoarsen._reduce_method

* Update tests for GH3376

* Incorporate review changes to test_dataset for GH3376

Remove commented-out test from test_coarsen_keep_attrs

Add test_rolling_keep_attrs

* Change Rolling._dataset_implementation for GH3376

Return a Dataset object that results in test_rolling_keep_attrs Passing

* style fixes

* Remove duplicate variable assignment and document change (GH3776)
#3821)

* removed mention that 'dims' are inferred from 'coords'-dict when omitted in DataArray (fixes #3820)

* added summary of PR #3821 to whats-new
* DOC: Add rioxarray link to examples and add example in file IO

* Add more external examples.

* fix spacing for ipython docs

* minor fixes

* fix bad edit

Co-authored-by: Deepak Cherian <[email protected]>
* note that n != periods in diff docstring

* better wording based on feedback
* Label Installed Versions details in GH Issue template

* Update bug_report.md
* update macos image

* whatsnew
* allow where to receive a callable

* Update xarray/core/common.py

Co-Authored-By: keewis <[email protected]>

* docstring

* whatsnew

Co-authored-by: keewis <[email protected]>
* quick fix, no docs, no tests

* added tests

* docstrings

* added whatsnew

* Update doc/whats-new.rst

Co-Authored-By: Maximilian Roos <[email protected]>

* Update doc/whats-new.rst

Co-Authored-By: keewis <[email protected]>

Co-authored-by: Maximilian Roos <[email protected]>
Co-authored-by: keewis <[email protected]>
* remove ScipyWriteBase class

* add whats new

Co-authored-by: Deepak Cherian <[email protected]>
* get the align tests to pass

* add pint to the upstream-dev ci job

* special case for booleans

* silence the pint behaviour change warning

* preprocess the unit mapping parameter to convert_units

* use assert_allclose and assert_identical instead

* clean up a few tests

* remove some xfails

* use the unit registry's quantity class

* explain the catch_warnings block

* don't use the function wrapper class if we don't need arguments

* whats-new.rst

* require the new pint version

* use functools.partial instead of function

* remove the convert_from parameter of array_attach_units

* make sure every top-level function test uses assert_units_equal

* hide the traceback of the unit comparison function

* considerably simplify the merge_dataarray test

* simplify the merge_dataset test
* installing.rst: update instructions

* whats-new

* explicit link and anchor

* :doc: -> :ref:
* start of doctest fixes

* start of doctest fixes
* Allow subtraction of a generic Index of cftime.datetimes from a CFTimeIndex

* black

* Test that NotImplemented logic works

* Vendor _get_nearest_indexer and _filter_indexer_tolerance

* Test OverflowError in __rsub__

* Fix name of pandas method in docstring

* Add what's new entries

* Enable use of tolerance greater than 292 years

* newlinw

Co-authored-by: Deepak Cherian <[email protected]>
* added test demonstrating interp bug for nd indexes sharing coordinate with array

* fix test so it works with sel

* support shared dimensions in interp

* isort fixes

* update whats new

* Revert "isort fixes"

This reverts commit 5df6c9c.

* test requires scipy
* Fix bug for multi-index with categorical values.

See issue #3674.

* Blacked.

* Add line in whats-new.rst.

* Remove forgotten print.

Co-authored-by: Matthieu Ancellin <[email protected]>
* fix a few erroneous doctest blocks

* blacken the doctest code

* manually remove the trailing comma from doctest lines
keewis and others added 29 commits August 19, 2020 22:06
* use merge instead of rebase

* update the delete-after-merge branch

* update whats-new.rst
* Fix polyfit fail on deficient rank

* Add docs and RankWarning

* Fix deficient ranks outputs | workaround dask bug | add tests

* Add a note to the doc | whats new entry

* Update xarray/core/nputils.py

Apply suggestion from review.

Co-authored-by: Mathias Hauser <[email protected]>

* Fix test and catch warnings

* forgot to run black

* adapt polyfit test to properly test issue #4190

* Fix syntax in doc/whats-new.rst

Co-authored-by: keewis <[email protected]>

Co-authored-by: Mathias Hauser <[email protected]>
Co-authored-by: keewis <[email protected]>
* Allow multiple dims to be passed with min_count

* Add whatsnew
* enumerate exclude_dims

* add tests

* xfail dask test (depends on 4060)

* add whats new

* add tests again (removed in merge)

* move exclude_dims to to_gufunc_string

* adapt tests

* move whats new to 16.1

* update docstring

Co-authored-by: Keewis <[email protected]>
* silence plot warnings (matplotlib 3.3)

* whats new

* updates from review

* suggestions from code review

* use assert_array_equal
* Allow cov & corr to handle missing values

* Remove artifacts

* Fix floating assert

* Update xarray/tests/test_computation.py

Co-authored-by: keewis <[email protected]>

* Add test for multiple explicit dims

* Use np.ma rather than drop=True

* Add whatsnew

* reformat

Co-authored-by: keewis <[email protected]>
* implement the fill_value mapping

* get per-variable fill_values to work in DataArray.reindex

* Update xarray/core/dataarray.py

Co-authored-by: Stephan Hoyer <[email protected]>

* check that the default value is used

* check that merge works with multiple fill values

* check that concat works with multiple fill values

* check that combine_nested works with multiple fill values

* check that Dataset.reindex and DataArray.reindex work

* check that aligning Datasets works

* check that Dataset.unstack works

* allow passing multiple fill values to full_like with datasets

* also allow overriding the dtype by variable

* document the dict fill values in Dataset.reindex

* document the changes to DataArray.reindex

* document the changes to unstack

* document the changes to align

* document the changes to concat and merge

* document the changes to Dataset.shift

* document the changes to combine_*

Co-authored-by: Stephan Hoyer <[email protected]>
* Allow chunk store for Zarr datasets

* Add test for open_zarr() chunk_store argument

* Add "chunk_store" argument to to_zarr()

* Simplify chunk_store argument handling

* blacken

* Add minimum zarr version requirement in docstring

* Update xarray/tests/test_backends.py

Co-authored-by: Ryan Abernathey <[email protected]>
Co-authored-by: dcherian <[email protected]>
Co-authored-by: Deepak Cherian <[email protected]>
* Added test for nd interpolation with nan

* Now ignoring NaNs in missing._localize

When interpolating with an nd indexer that contains NaN's, the code previously threw a KeyError from the missing._localize function. This commit fixes this by swapping `np.min` and `np.max` with `np.nanmin` and `np.nanmax`, ignoring any NaN values.

* Added `@requires_scipy` to test. Also updated what's new.

* Added numpy>=1.18 checks with `LooseVersion`

* Added checks for np.datetime64 type

This means the PR now also works for numpy < 1.18, as long as index is not with datetime

* Removed `raise ValueError` from previous commit

It seems that np.min/max works in place of nanmin/nanmax for datetime types for numpy < 1.18, see https://github.com/pydata/xarray/pull/3924/files

* Added datetime `NaT` test.

Also added a test for `Dataset` to `test_interpolate_nd_with_nan`, and "Missing values are skipped." to the dosctring of `interp` and `interp_like` methods of `DataArray` and `Dataset`.
#4391)

* move kwarg's `output_sizes` and `meta` to `dask_gufunc_kwargs` for internal use of `apply_ufunc` (follow-up to #4060, fixes #4385)

* add pull request referenz to `whats-new.rst`
* Remove deprecated usages of drop

* Formatting
* Pin pre-commit versions

* whatsnew

* Update doc/whats-new.rst

Co-authored-by: keewis <[email protected]>

* Update doc/whats-new.rst

Co-authored-by: keewis <[email protected]>
* Expose use_cftime option in open_zarr #2886

* Add test for open_zarr w/ use_cftime

* Formatting only

* Add entry in `whats-new.rst`

* Remove space

Co-authored-by: Anderson Banihirwe <[email protected]>
* Change isinstance checks to duck Dask Array checks #4208

* Use is_dask_collection in is_duck_dask_array

* Use is_dask_collection in is_duck_dask_array

* Revert to isinstance checks according to review discussion

* Move is_duck_dask_array to pycompat.py and use tokenize for comparisons

* isort

* Implement `is_duck_array` to replace `is_array_like`

* Rename `is_array_like` to `is_duck_array`

* `is_duck_array` checks for `__array_function__` and `__array_ufunc__`
  in addition to previous checks

* Replace checks for `is_duck_dask_array` and `__array_function__` with
  `is_duck_array`

* Skip numpy duck array tests when NEP18 is not active

* Use utils.is_duck_array in xarray/core/formatting.py

* Replace locally defined `is_duck_array` in _diff_mapping_repr

* Replace `"__array_function__"` and `is_duck_dask_array` check in
  `short_data_repr`

* Revert back to isinstance check for iris cube

* Add is_duck_array_or_ndarray function to utils

* Use is_duck_array_or_ndarray for duck array checks without NEP18

* Remove is_duck_dask_array_or_ndarray, replace checks with is_duck_array

* Add explicit check for NumPy array to is_duck_array

* Replace is_duck_array_or_ndarray checks with is_duck_array

* Remove is_duck_array check for deep copy

Co-authored-by: keewis <[email protected]>

* Use is_duck_array check in load

* Move duck dask array tokenize tests from test_units.py to test_dask.py

* Use _importorskip to require pint >=0.15 instead of pytest.mark.skipif

Co-authored-by: Deepak Cherian <[email protected]>
Co-authored-by: keewis <[email protected]>
* Remove meta_from_array

* Switch to dask.array.map_blocks

* No need to vendor median anymore.
* Align mypy versions

* whatsew

* Update doc/whats-new.rst
* WIP on silencing numpy warnings

* Remove testing expected warning

* Remove ignore warnings in tests; add xfail test for corner case

* _

* @keewis feedback

* Formatting

* Update xarray/tests/test_dataset.py

Co-authored-by: keewis <[email protected]>

* Update xarray/core/dataarray.py

* whatsnew

* Add note to xfailing test

* _

* Pacify pylance linter

* Add more tests for no errors

* Convert to docstring

Co-authored-by: keewis <[email protected]>
* Use a copy of dask_gufunc_kwargs

* Move copy inside else statement
* override the signature of plotfunc

* update whats-new.rst

* explain the reasons for the signature dummy
@phausamann phausamann merged commit 27c85fd into phausamann:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.