Repository navigation
feat(cli): add dream consolidation alias - #89
Conversation
|
Welcome, and sorry for the quiet first 10 hours — a review got drafted on our side and never submitted, which is on us. The alias registration is exactly right: same command object under a second name, and your is test proves it's not a copy. Two changes get this green and merged:
for name, cmd in group.commands.items(): That makes #87's "an alias adds no capability" mechanically true, and future aliases inherit it.
"""Run or preview memory compaction (weekly full or --nightly lightweight).
(and update your help-test string to match). Push those and I'll re-approve the workflow run — merging on green. |
|
No rush, just checking in since it's been a few days. Both changes are small — the If you'd rather hand it back, say the word and I'll finish it on your commit with your |
Signed-off-by: Aditya Datta <[email protected]>
1361cc7 to
e14ca40
Compare
Paul-Kyle
left a comment
There was a problem hiding this comment.
The requested alias-accounting and canonical-help corrections are both present on the current head. All seven checks are green — thank you.
|
Thanks for the follow-up. Both requested changes are now on the branch at e14ca40: the parity walker skips alias keys that point to the canonical command object, and the consolidation help restores the original summary with the alias note appended. I revalidated the current head with the focused alias and full surface-parity files (213 passed, 1 expected xfail) plus Ruff; all passed. |
Closes #87
Summary
palinode dreamas an alias of the existingconsolidateClick commandconsolidatevisible as the canonical name in help outputValidation
uv run --extra dev pytest tests/test_cli_dream_alias.py -q(2 passed)uv run ruff check palinode/cli/__init__.py palinode/cli/consolidate.py tests/test_cli_dream_alias.pygit diff --check