Skip to content

feat(cli): add dream consolidation alias - #89

Merged
Paul-Kyle merged 2 commits into
phasespace-labs:mainfrom
adity982:agent/dream-consolidation-alias
Aug 10, 2026
Merged

Paul-Kyle merged 2 commits into
phasespace-labs:mainfrom
adity982:agent/dream-consolidation-alias

Conversation

@adity982

@adity982 adity982 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Closes #87

Summary

  • register palinode dream as an alias of the existing consolidate Click command
  • keep consolidate visible as the canonical name in help output
  • add focused alias identity and help tests

Validation

  • uv run --extra dev pytest tests/test_cli_dream_alias.py -q (2 passed)
  • uv run ruff check palinode/cli/__init__.py palinode/cli/consolidate.py tests/test_cli_dream_alias.py
  • git diff --check

@Paul-Kyle

Copy link
Copy Markdown
Member

Welcome, and sorry for the quiet first 10 hours — a review got drafted on our side and never submitted, which is on us.

The alias registration is exactly right: same command object under a second name, and your is test proves it's not a copy. Two changes get this green and merged:

  1. The CI red is our surface-parity guard walking main.commands by key, so the alias key reads as an unregistered capability (only the ubuntu-3.12 failure is real; the other two lanes are fail-fast cancellations). Rather than registering dream in the parity contract, teach the walker that an alias key isn't a capability — in _live_cli_capabilities (tests/test_surface_parity.py):

for name, cmd in group.commands.items():
if name != cmd.name and group.commands.get(cmd.name) is cmd:
continue # alias key — same object is registered under its canonical name

That makes #87's "an alias adds no capability" mechanically true, and future aliases inherit it.

  1. The docstring swap costs the canonical help its real information — "or preview" and the weekly/--nightly modes are gone, and palinode consolidate --help now leads with alias trivia. Restore the original first line and append one sentence that reads correctly under both names:

"""Run or preview memory compaction (weekly full or --nightly lightweight).

palinode dream is an alias; palinode consolidate is the canonical name."""

(and update your help-test string to match).

Push those and I'll re-approve the workflow run — merging on green.

@Paul-Kyle

Copy link
Copy Markdown
Member

No rush, just checking in since it's been a few days. Both changes are small — the
alias-key skip in the parity walker, and restoring the docstring's original first line with
the alias note appended.

If you'd rather hand it back, say the word and I'll finish it on your commit with your
authorship preserved — no problem either way. If you're still on it, I'll re-approve the
workflow run as soon as you push.

@adity982
adity982 force-pushed the agent/dream-consolidation-alias branch from 1361cc7 to e14ca40 Compare August 10, 2026 13:41

@Paul-Kyle Paul-Kyle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested alias-accounting and canonical-help corrections are both present on the current head. All seven checks are green — thank you.

@Paul-Kyle
Paul-Kyle marked this pull request as ready for review August 10, 2026 15:11
@Paul-Kyle
Paul-Kyle merged commit 29ff599 into phasespace-labs:main Aug 10, 2026
7 checks passed
@adity982

Copy link
Copy Markdown
Contributor Author

Thanks for the follow-up. Both requested changes are now on the branch at e14ca40: the parity walker skips alias keys that point to the canonical command object, and the consolidation help restores the original summary with the alias note appended. I revalidated the current head with the focused alias and full surface-parity files (213 passed, 1 expected xfail) plus Ruff; all passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI: add palinode dream as an alias for consolidation

2 participants