Skip to content

Do not allow comparing objects of different types#772

Merged
guillep merged 1 commit intopharo-project:pharo-10from
guillep:fix/comparing-different-formats
Apr 29, 2024
Merged

Do not allow comparing objects of different types#772
guillep merged 1 commit intopharo-project:pharo-10from
guillep:fix/comparing-different-formats

Conversation

@guillep
Copy link
Copy Markdown
Member

@guillep guillep commented Apr 22, 2024

Even though they are both bytes/words, failing the primitive.

This prevents wrongly comparing wide strings with byte strings on a byte-per-byte basis.

…e both bytes/words, failing the primitive.

This prevents wrongly comparing wide strings with byte strings on a byte-per-byte basis.

Co-authored-by: doste <[email protected]>
@guillep guillep requested a review from doste April 22, 2024 09:22
@guillep guillep closed this Apr 22, 2024
@guillep guillep reopened this Apr 22, 2024
@guillep guillep closed this Apr 23, 2024
@guillep guillep reopened this Apr 23, 2024
@guillep guillep closed this Apr 26, 2024
@guillep guillep reopened this Apr 26, 2024
@guillep guillep merged commit 17ff0a5 into pharo-project:pharo-10 Apr 29, 2024
@guillep guillep deleted the fix/comparing-different-formats branch April 29, 2024 08:34
@guillep guillep mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant