Replace ‘scripts’ by Pharo script#14
Merged
jecisc merged 1 commit intopharo-project:svgPackfrom Aug 27, 2024
Merged
Conversation
…the ‘README.md’ file.
Contributor
Author
|
@jecisc Could you maybe check whether this can be merged? |
astares
reviewed
Jul 17, 2024
astares
approved these changes
Aug 20, 2024
Member
|
This is nice. |
Contributor
Author
|
I’m not sure that’s something to be dealt with in this pull request, I opened an issue about it: Pharo issue #17017. |
Contributor
Author
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces the scripts in the ‘scripts’ directory by a Pharo script in the ‘README.md’ file. By default it only generates the PNG files that don’t already exist, so that they are only generated for newly added icons. The variable ‘shouldRegenerateAll’ can be set to ‘true’ to regenerate them for all icons. Inkscape seems to treat a missing source SVG file as a warning, rather than error, condition and doesn’t exit with a non-zero status in that case, hence the script explicitly checks that the PNG file exists after executing the shell command for generating it.