Add override for #drawPolygon:fillStyle:borderWidth:borderColor: on ScalingCanvas to avoid conversion of the second argument to a Color#16304
Merged
Ducasse merged 3 commits intopharo-project:Pharo12from Mar 22, 2024
Conversation
… ScalingCanvas to avoid the inherited implementation’s conversion of the second argument to a Color.
…cCoreDependencies on SystemDependenciesTest to changes in commit b06aabd (“Added #exampleRubScrolledTextMorph for ScalingCanvas”).
Rinzwind
added a commit
to Rinzwind/pharo
that referenced
this pull request
Mar 22, 2024
…for #drawPolygon:fillStyle:borderWidth:borderColor: on ScalingCanvas to avoid conversion of the second argument to a Color”) to Pharo 11.
Contributor
Author
|
I updated the ‘Retina display’ scaling Pharo 11 backport in the branch ‘scaling-canvas-tryout-16-pharo11’ (commit 3cbdb6e). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds an override for
#drawPolygon:fillStyle:borderWidth:borderColor:on ScalingCanvas to avoid the inherited implementation’s conversion of the second argument to a Color. In combination with the changes of pull request #16303, this fixes the drawing of a RubAdornmentDisplayer on a ScalingCanvas, an example for that is added as well.