Skip to content

Fix ‘span’ in BalloonEngine not being as wide as the ‘destForm’#14926

Merged
Ducasse merged 1 commit intopharo-project:Pharo12from
Rinzwind:fix-balloonengine-span
Oct 9, 2023
Merged

Fix ‘span’ in BalloonEngine not being as wide as the ‘destForm’#14926
Ducasse merged 1 commit intopharo-project:Pharo12from
Rinzwind:fix-balloonengine-span

Conversation

@Rinzwind
Copy link
Copy Markdown
Contributor

@Rinzwind Rinzwind commented Oct 8, 2023

This pull request makes #bitBlt: on BalloonEngine set a new ‘span’ when ‘bitBlt’ is set so that the width of the ‘span’ is not less than the width of the ‘destForm’ of the new ‘bitBlt’. This fixes issue #14925. The method #initializeSpan is removed as #initialize also sends #bitBlt:.

…hat its width is less than the width of the ‘destForm’ of the new ‘bitBlt’, and removed #initializeSpan.
@Rinzwind
Copy link
Copy Markdown
Contributor Author

Rinzwind commented Oct 9, 2023

I made some improvements to the ‘Retina display’ scaling experiment from earlier pull requests: commits 9fd9b95, ea04bfc, 37bb5a8, e5d93ff, 0279cd4 and d731cc5 (these commits are not included in this pull request). The change to #drawPolygon:color:borderWidth:borderColor: in commit ea04bfc is what required fixing issue #14925.

In the extra world opened by OSWorldRendererScalingCanvas example, previously the colors of code critic highlights got muted, that has been fixed now:

You can try it out: create an image in Pharo Launcher using Pharo 12 build 869 as the template, repair the repository ‘pharo’ by cloning from GitHub using ‘Rinzwind’ as the ‘Owner name’ and ‘pharo’ as the ‘Project name’, then check out the branch ‘scaling-canvas-tryout-9’, and do OSWorldRendererScalingCanvas example.

To avoid some issues with extra worlds (issues #14585 and #14817), you can also try using ScalingCanvas for drawing the main world. First do: OSWorldRendererScalingCanvas isApplicable: true. Then save and quit the image, and open it again. Then do: World scaleFactor: 0.5. If you need to revert, do World scaleFactor: 1 and OSWorldRendererScalingCanvas isApplicable: false, then save and reopen.

@Ducasse
Copy link
Copy Markdown
Member

Ducasse commented Oct 9, 2023

Hi kris

if this PR depends on ea04bfc then do you have a PR for ea04bfc?

@Rinzwind
Copy link
Copy Markdown
Contributor Author

Rinzwind commented Oct 9, 2023

It’s the other way around: commit ea04bfc depends on this pull request but it is not included in this pull request. The only change in this pull request is the move of the assignment to ‘span’ in BalloonEngine (see the ‘Files changed’ tab).

@Ducasse
Copy link
Copy Markdown
Member

Ducasse commented Oct 9, 2023

Thanks for the explanation.

@Ducasse Ducasse merged commit cb05d7a into pharo-project:Pharo12 Oct 9, 2023
@Rinzwind Rinzwind deleted the fix-balloonengine-span branch October 10, 2023 10:14
Rinzwind added a commit to Rinzwind/pharo that referenced this pull request Nov 1, 2023
… BalloonEngine not being as wide as the ‘destForm’”) to Pharo 11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants