feat: add smallserial metadata#899
Merged
davecramer merged 1 commit intopgjdbc:masterfrom Sep 30, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
============================================
+ Coverage 68.67% 68.67% +<.01%
- Complexity 3891 3893 +2
============================================
Files 179 179
Lines 16391 16401 +10
Branches 2669 2673 +4
============================================
+ Hits 11256 11263 +7
Misses 3887 3887
- Partials 1248 1251 +3 |
Member
|
I'm curious does anyone actually use smallserial ? We've never had a request for this. |
Member
Author
|
I use it 😝, this is essentially metadata which most people don't use, its added for completeness. |
Member
|
I wonder if we should delay this till 42.2.0 due to "new feature" nature of the PR. |
Member
Author
|
It's not such a big feature, but it's fine to delay this till 42.2.0, it's not especially important as noted by Dave. |
Member
Author
|
Should I add a check of the version of Postgres? |
Member
|
+1 |
jorsol
force-pushed
the
smallserial-metadata
branch
from
1325c4c to
46d13c1
Compare
Member
Author
|
Ready the check for ServerVersion.v9_2 |
jorsol
force-pushed
the
smallserial-metadata
branch
from
46d13c1 to
d6842ad
Compare
Member
Author
|
This feature is ready for 42.2.0, comments are welcome. |
jorsol
force-pushed
the
smallserial-metadata
branch
from
d6842ad to
2db1ef8
Compare
Member
Author
|
Rebased and ready for 42.2.0 |
jorsol
force-pushed
the
smallserial-metadata
branch
3 times, most recently
from
2c28cb4 to
7cdfe43
Compare
Member
Author
|
Should this be included in 42.2.1? |
jorsol
force-pushed
the
smallserial-metadata
branch
from
7cdfe43 to
779636c
Compare
jorsol
force-pushed
the
smallserial-metadata
branch
from
779636c to
9882612
Compare
vlsi
force-pushed
the
master
branch
2 times, most recently
from
c25d807 to
adcb194
Compare
jorsol
force-pushed
the
smallserial-metadata
branch
2 times, most recently
from
c1e7cb3 to
dd044ce
Compare
Member
Author
|
Resurrecting this for completeness with #1899
|
PostgreSQL 9.2 adds a SMALLSERIAL data type, this reports the correct metadata information when a column is a smallserial (int2 with sequence), similar to how a serial or bigserial data types are reported.
jorsol
force-pushed
the
smallserial-metadata
branch
from
dd044ce to
dec8db1
Compare
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
============================================
+ Coverage 69.02% 69.18% +0.15%
- Complexity 4198 4211 +13
============================================
Files 197 197
Lines 17998 18004 +6
Branches 2917 2919 +2
============================================
+ Hits 12424 12456 +32
+ Misses 4223 4202 -21
+ Partials 1351 1346 -5 |
Member
|
ah, thanks good catch. I'll push shortly |
davecramer
pushed a commit
to davecramer/pgjdbc
that referenced
this pull request
Oct 1, 2020
PostgreSQL 9.2 adds a SMALLSERIAL data type, this reports the correct metadata information when a column is a smallserial (int2 with sequence), similar to how a serial or bigserial data types are reported.
davecramer
pushed a commit
to davecramer/pgjdbc
that referenced
this pull request
Oct 2, 2020
PostgreSQL 9.2 adds a SMALLSERIAL data type, this reports the correct metadata information when a column is a smallserial (int2 with sequence), similar to how a serial or bigserial data types are reported.
davecramer
added a commit
that referenced
this pull request
Oct 6, 2020
* fix: avoid removal type annotations on "this" so the source archive is buildable "this" type annotations are Java 8+, so we no longer need to remove them. * fix: PgTokenizer was ignoring last empty token (#1882) * fix: PgTokenizer was ignoring last empty token fixes #1881 * fix: handle smallserial correctly fixes #1897 (#1899) * feat: add smallserial metadata (#899) PostgreSQL 9.2 adds a SMALLSERIAL data type, this reports the correct metadata information when a column is a smallserial (int2 with sequence), similar to how a serial or bigserial data types are reported. * fix:remove osgi from karaf fixes Issue #1891 (#1902) * Change default of gssEncMode to ALLOW. PostgreSQL can deal with PREFER but there are cloud providers that did not implement the protocol properly. Using PREFER seems to cause more problems than it solves Co-authored-by: Vladimir Sitnikov <[email protected]> Co-authored-by: Jorge Solorzano <[email protected]>
davecramer
added a commit
that referenced
this pull request
Oct 8, 2020
* fix: avoid removal type annotations on "this" so the source archive is buildable "this" type annotations are Java 8+, so we no longer need to remove them. * fix: PgTokenizer was ignoring last empty token (#1882) * feat: add smallserial metadata (#899) PostgreSQL 9.2 adds a SMALLSERIAL data type, this reports the correct metadata information when a column is a smallserial (int2 with sequence), similar to how a serial or bigserial data types are reported. * fix:remove osgi from karaf fixes Issue #1891 (#1902) * Change default of gssEncMode to ALLOW. PostgreSQL can deal with PREFER but there are cloud providers that did not implement the protocol properly * update CHANGELOG and posts for 42.2.17 * fix up CHANGELOG * Update README, gssEncMode for release Co-authored-by: Vladimir Sitnikov <[email protected]> Co-authored-by: Jorge Solorzano <[email protected]>
davecramer
added a commit
to davecramer/pgjdbc
that referenced
this pull request
Nov 16, 2020
* fix: avoid removal type annotations on "this" so the source archive is buildable "this" type annotations are Java 8+, so we no longer need to remove them. * fix: PgTokenizer was ignoring last empty token (pgjdbc#1882) * feat: add smallserial metadata (pgjdbc#899) PostgreSQL 9.2 adds a SMALLSERIAL data type, this reports the correct metadata information when a column is a smallserial (int2 with sequence), similar to how a serial or bigserial data types are reported. * fix:remove osgi from karaf fixes Issue pgjdbc#1891 (pgjdbc#1902) * Change default of gssEncMode to ALLOW. PostgreSQL can deal with PREFER but there are cloud providers that did not implement the protocol properly * update CHANGELOG and posts for 42.2.17 * fix up CHANGELOG * Update README, gssEncMode for release Co-authored-by: Vladimir Sitnikov <[email protected]> Co-authored-by: Jorge Solorzano <[email protected]>
1 task
1 task
1 task
This was referenced Apr 5, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add smallserial metadata info.