Create DisabledIfServerGreater annotation #3937
Merged
davecramer merged 1 commit intopgjdbc:masterfrom Feb 11, 2026
Merged
Conversation
…er server versions
sehrope
reviewed
Feb 14, 2026
Comment on lines
+470
to
475
| @DisabledIfServerVersionGreater("19") | ||
| @Test | ||
| public void testSingleQuotes() throws SQLException { | ||
| // This test is only relevant for PostgreSQL 18 and below | ||
| // as of 4576208 in postgres non-standard strings now throw an error. | ||
| assumeMinimumServerVersion(ServerVersion.v18); | ||
|
|
Member
There was a problem hiding this comment.
Previously this test would only run if the version was >=18.
With this change it only runs if it's <=18.
Is that intentional? Alternatively, am I misunderstanding how these methods work?
Member
Author
There was a problem hiding this comment.
Correct, the change was in 19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for disabling tests for newer server versions