Skip to content

fix: Update release plugin config to use .set(...) for props and inject nexus secrets via props#3802

Merged
sehrope merged 1 commit intopgjdbc:masterfrom
sehrope:fix-release-workflow
Sep 18, 2025
Merged

fix: Update release plugin config to use .set(...) for props and inject nexus secrets via props#3802
sehrope merged 1 commit intopgjdbc:masterfrom
sehrope:fix-release-workflow

Conversation

@sehrope
Copy link
Member

@sehrope sehrope commented Sep 18, 2025

@davecramer Eyeball this one and I guess let's try it out.

@vlsi
Copy link
Member

vlsi commented Sep 18, 2025

Could you please clarify the reason for the change?

@sehrope
Copy link
Member Author

sehrope commented Sep 18, 2025

Hopefully to fix releasing to actually work: https://github.com/pgjdbc/pgjdbc/actions/runs/17837108128

Unless you think it's something else that's causing it. The error in that run is complaining that the username is not populated.

@sehrope
Copy link
Member Author

sehrope commented Sep 18, 2025

@vlsi Are you going to fix the release workflow or have an alternative idea as to what's wrong? If so, let us know, otherwise going to proceed with this in a few minutes to try it out.

@sehrope sehrope merged commit ec5a088 into pgjdbc:master Sep 18, 2025
16 of 17 checks passed
@vlsi
Copy link
Member

vlsi commented Sep 18, 2025

Exactly the same code works for me in a different project: https://github.com/Netcracker/qubership-profiler-agent/blob/c71efd9d52f6d61ddc608d1a46ea9437fa04e3b8/build-logic/root-build/src/main/kotlin/build-logic.root-build.gradle.kts#L10

I don't see reasons to go for properties and so on. So I wonder why do you suggest the changes

@vlsi
Copy link
Member

vlsi commented Sep 18, 2025

Note: you can debug release workflows in your fork repository, so you don't need to merge fixes just to test them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments