test: extract pgjdbc/testFixtures to testkit project#3666
Merged
vlsi merged 6 commits intopgjdbc:masterfrom Jun 17, 2025
Merged
test: extract pgjdbc/testFixtures to testkit project#3666vlsi merged 6 commits intopgjdbc:masterfrom
vlsi merged 6 commits intopgjdbc:masterfrom
Conversation
vlsi
force-pushed
the
testkit
branch
7 times, most recently
from
81af3d6 to
0c971ff
Compare
Member
Author
|
Looks like this is ready. Now both osgi-test and benchmark modules consume the shaded artifact. At the same time, as we move |
vlsi
force-pushed
the
testkit
branch
3 times, most recently
from
f98807b to
8f6bee2
Compare
vlsi
changed the title
It enables using shadowed artifacts for benchmarks and osgi-test
… distribution It allows developers to verify the source distribution with a single command.
…junit-platform-launcher, remove junit4 Previously, junit-platform-launcher was missing in the dependencies, so the test execution failed. We did not notice it as Fedora provided an older JUnit (~5.10) which did not surface the error.
…ramework Different projects might have different dependencies, so we can't have global stubs as they might refer third-party classes. The common stubs (e.g. for java.sql) can still be located under config/checkerframework.
Previously, the code was located under pgjdbc/src/test/..., and we do not verify nullability annotations for test code. Now the code locates under testkit/src/main, so the strict nullability verification is in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It enables using shadowed artifacts for
benchmarksandosgi-test