test: simplify TestUtil.openDB, add tests with various assumeMinServerVersion values#3614
Merged
vlsi merged 1 commit intopgjdbc:masterfrom May 3, 2025
Merged
test: simplify TestUtil.openDB, add tests with various assumeMinServerVersion values#3614vlsi merged 1 commit intopgjdbc:masterfrom
vlsi merged 1 commit intopgjdbc:masterfrom
Conversation
10096bb to
4c3dfa4
Compare
…rVersion values Previously, the code considered only a few of PGProperty names when creating a database connection. So there was no possibility to set the rest of the properties by passing them with build.properties or -D... After the change, the code uses all the matching properties from System.properties, so we can increase test coverage. For instance, the change adds tests with assumeMinServerVersion setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the code considered only a few of PGProperty names when creating a database connection. So there was no possibility to set the rest of the properties by passing them with build.properties or -D...
After the change, the code uses all the matching properties from System.properties, so we can increase test coverage.
For instance, the change adds tests with assumeMinServerVersion setting.
I still do not like how
Propertiescontents is copied all over the place, however, we can't do better as we do not haveProperties(List<Properties>)factory yet.This test would have caught #3508 earlier.
The idea behind the change is:
PGProperty). For instance, previously,build.propertiesincluded a property namedusernamewhich was handled in a special way sincePGProperty.USERhas a value ofuser.That is the reason I changed
servertotest.url.PGHOSTwhich effectively means "use it as a default PGHOST value, and pass it via the URL rather than props object)TestUtil. Thetest.url.prefix allows to configure which properties should be passed with the URL (TestUtilstrips the prefix and adds the rest as a query parameter, etc)