perf: parse SQL to a single string, not a array of fragments#311
Merged
davecramer merged 1 commit intopgjdbc:masterfrom Jun 28, 2015
Merged
perf: parse SQL to a single string, not a array of fragments#311davecramer merged 1 commit intopgjdbc:masterfrom
davecramer merged 1 commit intopgjdbc:masterfrom
Conversation
vlsi
force-pushed
the
statementParsing
branch
4 times, most recently
from
829d860 to
952d738
Compare
This saves a bit of cycles when encoding the query to UTF8 (the whole query can be encoded at once)
vlsi
changed the title
Contributor
There was a problem hiding this comment.
Something like nativeSql.length() + 3 * bindPositions.length might save a StringBuilder resize in the common case? (Or 2 * bindPositions.length if we expect the number of bound parameters to be < 10 in almost all cases)
vlsi
added a commit
to Gordiychuk/pgjdbc
that referenced
this pull request
Jun 29, 2015
Rename toIntList to toIntArray, use better estimation for NativeQuery.toString result size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves a bit of cycles when encoding the query to UTF8 (the whole query can be encoded at once)
I've updated both V2 and V3 queries.
?? -> ? replacing is folded into the parse process.