Repository navigation
Guard pg_query.go with not windows as well - #105
Merged
Merged
Conversation
lfittl
approved these changes
Dec 5, 2023
lfittl
left a comment
lfittl
left a comment
Member
There was a problem hiding this comment.
👍 I think that works until we add Windows support.
That said, be aware that this may cause a compatibility break if you solely rely on this to decide whether pg_query's internal logic is used (i.e. make sure that you don't break if this check suddenly goes away when we add Windows support directly).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #102, in sqlc-dev/sqlc#3027 we are trying to allow sqlc to run on windows using the wasm pgquery, even when cgo is enabled (this would allow windows to support both postgresql engine and wasmtime plugins). So it turned out we need to guard the cgo build from this repository against windows as well since it otherwise tries to compile and fail as we found in https://github.com/sqlc-dev/sqlc/pull/3035/files
I didn't add to the test files like before since it didn't seem necessary but let me know
/cc @kyleconroy