Repository navigation
Allow importing parse tree proto with cgo disabled - #102
Merged
Merged
Conversation
This was referenced Dec 1, 2023
Member
|
Thanks for the contribution! - I think that seems acceptable and doesn't hurt the use case where cgo is available. I'll push up a small adjustment to also add the same build tag to the test files in the top level folder, so running |
lfittl
approved these changes
Dec 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am interested in using just the proto definition in an environment without cgo. Currently, this does not work because
parserpackage requires cgo, and Go doesn't allow a package with no Go filespg_query.goimports names fromparserand requires cgoWould this change be OK to allow the proto to be used by itself without cgo required?