clang-tidy: check and fix cppcoreguidelines-virtual-class-destructor by Kushagra0811 · Pull Request #3029 · pgRouting/pgrouting

Kushagra0811 · 2026-01-12T11:20:58Z

Description
This PR enables the cppcoreguidelines-virtual-class-destructor check in .clang-tidy and fixes the warnings currently present in the codebase.

Changes

Modified .clang-tidy to enable the check.
Added virtual ~ClassName() = default; to the following classes:
- Pgr_bdAstar in include/bdAstar/bdAstar.hpp
- Pgr_bdDijkstra in include/bdDijkstra/bdDijkstra.hpp
- Pgr_bidirectional in include/cpp_common/bidirectional.hpp
- Pgr_kruskal in include/spanningTree/kruskal.hpp
- Pgr_mst in include/spanningTree/mst.hpp
- Pgr_prim in include/spanningTree/prim.hpp

Verification
Built locally with clang-tidy enabled using:
CXX=clang++ CC=clang cmake -DUSE_CLANG_TIDY=ON ..
Result: Build completed successfully with no warnings generated for this check.

Summary by CodeRabbit

Chores
- Updated internal code quality configurations and standards compliance across the codebase.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-12T11:21:11Z

Walkthrough

The PR removes the cppcoreguidelines-virtual-class-destructor check from .clang-tidy configuration and adds or modifies destructors across six base classes (Pgr_bdAstar, Pgr_bdDijkstra, Pgr_bidirectional, Pgr_kruskal, Pgr_mst, Pgr_prim) to be virtual, enabling proper polymorphic cleanup when deleting through base class pointers.

Changes

Cohort / File(s)	Summary
Configuration Update `.clang-tidy`	Removed `cppcoreguidelines-virtual-class-destructor` check while retaining `cppcoreguidelines-use-default-member-init`; no other semantic changes to configuration
Virtual Destructors - Pathfinding Algorithms `include/bdAstar/bdAstar.hpp`, `include/bdDijkstra/bdDijkstra.hpp`, `include/cpp_common/bidirectional.hpp`	Made destructors virtual in Pgr_bdAstar, Pgr_bdDijkstra, and Pgr_bidirectional classes; signature changed from `~ClassName() = default;` to `virtual ~ClassName() = default;`
Virtual Destructors - Spanning Tree Algorithms `include/spanningTree/kruskal.hpp`, `include/spanningTree/mst.hpp`, `include/spanningTree/prim.hpp`	Added public virtual destructors to Pgr_kruskal, Pgr_mst, and Pgr_prim classes with `virtual ~ClassName() = default;`

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

clang-tidy: fix assert.hpp cppcoreguidelines-explicit-virtual-functions #3005 — Both PRs modify .clang-tidy configuration and update class destructor signatures with virtual annotations across multiple files

Suggested labels

Enhancement, C/C++

Suggested reviewers

cvvergara
robe2

Poem

🐰 Virtual destructors bloom with care,
Base classes cleaned with flair,
No more warnings from the linter's sight,
Polymorphic cleanup done just right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: enabling a clang-tidy check and fixing related violations by adding virtual destructors to multiple classes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d9c911 and eaee113.

📒 Files selected for processing (7)

.clang-tidy
include/bdAstar/bdAstar.hpp
include/bdDijkstra/bdDijkstra.hpp
include/cpp_common/bidirectional.hpp
include/spanningTree/kruskal.hpp
include/spanningTree/mst.hpp
include/spanningTree/prim.hpp

🧰 Additional context used

🧠 Learnings (3)

📚 Learning: 2026-01-06T20:27:43.082Z

Learnt from: cvvergara
Repo: pgRouting/pgrouting PR: 3026
File: src/ordering/sloanOrdering.cpp:46-89
Timestamp: 2026-01-06T20:27:43.082Z
Learning: In pgRouting, the team plans to eventually stop using the base graph class wrappers. Direct Boost Graph Library calls (e.g., `boost::num_vertices(graph.graph)`) are acceptable and preferred over wrapper methods (e.g., `graph.num_vertices()`) as this future-proofs the code against the planned removal of the base class.

Applied to files:

include/spanningTree/mst.hpp
include/spanningTree/prim.hpp

📚 Learning: 2025-12-30T19:45:24.426Z

Learnt from: cvvergara
Repo: pgRouting/pgrouting PR: 3004
File: .clang-tidy:9-11
Timestamp: 2025-12-30T19:45:24.426Z
Learning: In .clang-tidy files (and similar list-based configuration files), the last entry in a list should not have a trailing comma, following project convention. Enforce that lists do not end with a comma to improve diffs and consistency across configuration files.

Applied to files:

.clang-tidy

📚 Learning: 2025-12-30T19:45:40.183Z

Learnt from: cvvergara
Repo: pgRouting/pgrouting PR: 3004
File: .clang-tidy:11-11
Timestamp: 2025-12-30T19:45:40.183Z
Learning: In any .clang-tidy configuration files, ensure that the last element of a list does not have a trailing comma, to follow the repository's coding convention. This applies to all pgRouting/.clang-tidy files across the codebase.

Applied to files:

.clang-tidy

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Codacy Static Code Analysis

🔇 Additional comments (7)

include/spanningTree/mst.hpp (1)

53-55: LGTM!

Adding a public virtual destructor to Pgr_mst is the correct fix. Since this class has a pure virtual function (generate_mst) and serves as a base for Pgr_kruskal and Pgr_prim, a virtual destructor ensures proper polymorphic destruction when deleting derived objects through a base class pointer.

.clang-tidy (1)

29-29: LGTM!

Removing the -cppcoreguidelines-virtual-class-destructor exclusion (which was previously in this list) correctly enables the check. The formatting follows the project convention with no trailing comma on the last entry.

include/spanningTree/prim.hpp (1)

54-54: LGTM!

Adding the explicit virtual destructor maintains consistency with the base class and satisfies the clang-tidy check. While Pgr_prim inherits a virtual destructor from Pgr_mst, explicitly marking it as virtual improves clarity.

include/bdAstar/bdAstar.hpp (1)

81-81: LGTM!

The explicit virtual destructor is consistent with the changes to the base class Pgr_bidirectional and the pattern applied across this PR.

include/spanningTree/kruskal.hpp (1)

45-45: LGTM!

Adding the explicit virtual destructor maintains consistency with the base class Pgr_mst and satisfies the clang-tidy check.

include/cpp_common/bidirectional.hpp (1)

81-81: LGTM!

Adding virtual to the destructor is correct and necessary. Pgr_bidirectional has pure virtual functions (explore_forward, explore_backward), so it must have a virtual destructor to ensure proper polymorphic destruction when derived objects are deleted through base class pointers.

include/bdDijkstra/bdDijkstra.hpp (1)

80-80: LGTM!

The explicit virtual keyword is technically redundant since the base class Pgr_bidirectional<G> already has a virtual destructor (making this one implicitly virtual), but it's acceptable for clarity and consistency with other classes in this PR.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cvvergara

I liked the option you decided, public virtual
Thanks for contributing

Kushagra0811 · 2026-01-18T11:49:01Z

Thanks for the review! Glad the public virtual approach was the right fit.
Happy to contribute.

clang-tidy: check and fix cppcoreguidelines-virtual-class-destructor

eaee113

This was referenced Jan 12, 2026

Task 4: Get familiar with C++ Kushagra0811/GSoC-pgRouting#3

Open

Intent of Application - Kushagra Gupta pgRouting/GSoC-pgRouting#519

Closed

cvvergara added Enhancement C/C++ labels Jan 13, 2026

cvvergara added this to the Release 4.1.0 milestone Jan 13, 2026

cvvergara approved these changes Jan 16, 2026

View reviewed changes

cvvergara merged commit 6b16089 into pgRouting:develop Jan 17, 2026
59 checks passed

cvvergara linked an issue Jan 28, 2026 that may be closed by this pull request

Check and fix cppcoreguidelines-virtual-class-destructor #3040

Closed

This was referenced Feb 7, 2026

clang-tidy: fix explicit virtual functions in remaining headers #3063

Merged

clang-tidy: check and fix cppcoreguidelines-use-default-member-init #3065

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

clang-tidy: check and fix cppcoreguidelines-virtual-class-destructor#3029

clang-tidy: check and fix cppcoreguidelines-virtual-class-destructor#3029
cvvergara merged 1 commit into
pgRouting:developfrom
Kushagra0811:fix-cppcoreguidelines-virtual-class-destructor

Kushagra0811 commented Jan 12, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jan 12, 2026 •

edited

Loading

Uh oh!

cvvergara left a comment

Uh oh!

Uh oh!

Kushagra0811 commented Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Kushagra0811 commented Jan 12, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

cvvergara left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Kushagra0811 commented Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Kushagra0811 commented Jan 12, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jan 12, 2026 •

edited

Loading