Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syndicated Links Displaying to the Far Left #10

Closed
mrkrndvs opened this issue Dec 17, 2017 · 29 comments
Closed

Syndicated Links Displaying to the Far Left #10

mrkrndvs opened this issue Dec 17, 2017 · 29 comments

Comments

@mrkrndvs
Copy link

I really like ZenPress, but have been wondering about the inclusion of Syndicated Links. They are presented in the far left. Is this intentional? Is it something in the Syndication Links Plugin?

screenshot 2017-12-17 at 9 58 52 pm

@pfefferle
Copy link
Owner

It is a theme problem, thanks for reporting, I will have a look!

@dshanske
Copy link

Would you consider integrating support? You can unhook the content filter and call the display directly

@pfefferle
Copy link
Owner

pfefferle commented Dec 17, 2017

sure, but both should work

@mrkrndvs
Copy link
Author

@pfefferle the strange formatting also occurs when you search for something

zenpress search

Assume that this is probably different, but I thought that I would add it here, just in case it is related.

@pfefferle
Copy link
Owner

Do you use the latest master version?

@mrkrndvs
Copy link
Author

My previous version had been installed November 17. Just uploaded the latest Master. Both errors still there.

@pfefferle
Copy link
Owner

Hmm, I will have a Look, I can’t reproduce it at my blog.

@pfefferle
Copy link
Owner

Can you post the URL of the blog here?

@pfefferle
Copy link
Owner

do you use any plugins that hooks into the post content? there is no <p> element around the paragraphs... that's why it shows up full size.

@pfefferle
Copy link
Owner

Syndication Links Plugin is using a span element, so it can't be centered... I filed an issue there.

@mrkrndvs
Copy link
Author

Thank you

@pfefferle
Copy link
Owner

@mrkrndvs I committed a native implementation of Syndication Links, I am curious about your thoughts.

bildschirmfoto 2018-02-12 um 22 03 33

@pfefferle
Copy link
Owner

Ah, I saw you switched the theme... never mind ;)

@mrkrndvs
Copy link
Author

Looks good @pfefferle. I notice that the search still has a SPAN issue?

screenshot 2018-02-13 at 10 51 41 pm

Also, I have collected some thoughts here.

@pfefferle
Copy link
Owner

@mrkrndvs do you use Gutenberg?

@pfefferle
Copy link
Owner

I tried to optimize the plugin with Gutenberg, so that you will be able to use content that is wider than the normal content, like here: https://notiz.blog/2017/12/07/zwoelf/ or here: https://notiz.blog/2017/10/04/readability/

But that means, that you always have to have an element surrounding the text inside the content-<div>... This shouldn't be a problem, because at least there should be a <p> element, but sometimes, plugins add text directly to the div, so it causes this issue.

@pfefferle
Copy link
Owner

I just saw that you have build your own child-theme and that you simply include the style.css, but this is not enough, I splitted the view-port dependent stuff into several stylesheets. You have to include 5 styles in total: https://github.com/pfefferle/ZenPress/blob/master/functions.php#L232

@mrkrndvs
Copy link
Author

What forced me to change was the headless notes rss. This would not be an issue with my main site which is just for 'Articles'.

@mrkrndvs
Copy link
Author

When I get a chance I will also turn off the plugins one by one and try and identify what is causing the issue with the search screen.

@pfefferle
Copy link
Owner

what was the problem with the "headless notes rss"?

@mrkrndvs
Copy link
Author

Micro.blog requires 'no titles':

Part of indie microblogging is getting back to the simplicity of title-less posts. When you’re writing a microblog post in WordPress, just leave the title blank, and if necessary update the post template to not include the title in HTML or the RSS feed.(source)

For some reason it the posts were producing a "No Title" Title, so I tried David's 2016 (which I know does not have headings for notes) and it did worked.

Not sure if that makes sense.

pfefferle added a commit that referenced this issue Feb 13, 2018
for a better compatibility with micto.blog.

thanks @mrkrndvs for the hint

see the discussion here #10
@pfefferle
Copy link
Owner

thanks for the hint @mrkrndvs, the latest commit should fix that problem.

@mrkrndvs
Copy link
Author

mrkrndvs commented Feb 13, 2018 via email

@mrkrndvs
Copy link
Author

@pfefferle I have had a second go at getting a child theme developed by @chrisaldrich working again with no success. I added all the stylesheets, but there is still aspects of the parent theme that are not coming through.

@mrkrndvs
Copy link
Author

Do I need to add Gutenberg for it to work?

@pfefferle
Copy link
Owner

No, you do not need Gutenberg... I think I have to release a "Client-Theme skeleton" to test it by myself...

@pfefferle
Copy link
Owner

Thanks for the feedback!

@mrkrndvs
Copy link
Author

Updated the theme for Read Write Respond from ZenPress to Autonomie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants