merge #13
Merged
merge #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix dataviews scroll and footer stickiness * Add back colors to admin-ui-page * use more specific property * header padding * Enable text labels in admin ui header actions * reintroduce padding prop as default false
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: westonruter <[email protected]>
…#72192) Co-authored-by: t-hamano <[email protected]> Co-authored-by: jeffpaul <[email protected]> Co-authored-by: Mamaduka <[email protected]>
…ordPress#72158) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: adamsilverstein <[email protected]> Co-authored-by: theminaldiwan <[email protected]>
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]>
…2191) Co-authored-by: t-hamano <[email protected]> Co-authored-by: tellthemachines <[email protected]>
… links retaining bindings (WordPress#72162) * Navigation Link: Fix custom links creating empty block bindings When manually inserting a Custom Link variation of the Navigation Link block, empty block bindings were being created. This occurred because the binding logic only checked for the presence of an 'id' attribute without verifying whether the link was actually an entity link vs a custom link. This commit refactors the binding logic to be based on the final computed state from updateAttributes rather than the input values, preventing the mismatch and ensuring custom links never create bindings. Changes: - Refactor updateAttributes to return metadata about final state - Update onChange handlers to use returned isEntityLink flag - Add comprehensive test coverage for return value metadata - Ensure binding decisions align with computed attributes Fixes the bug where Custom Link variations would incorrectly create bindings even though they have kind: 'custom' and should remain unbound. * Fix: Use isEntityLink metadata for binding decisions in Navigation blocks - Updated Navigation Link and Navigation Submenu edit components to use isEntityLink metadata from updateAttributes - Fixed menu-inspector-controls to use useEntityBinding hook for consistency - Ensures bindings are only created for entity links (posts, pages, taxonomies) - Prevents empty bindings from being created for custom links - Fixes bug where severing entity links would incorrectly retain bindings Co-authored-by: getdave <[email protected]> Co-authored-by: scruffian <[email protected]>
…67560) * PoC adding the additional field to inline links only * Output the class attribute correctly in HTML * Ensure class is part of link format active attributes * Ensure full width inputs * Implement Toggleable control for CSS classes * Simplify settings render property validation - Remove complex try-catch blocks and null/undefined checks - Simplify to just check typeof setting.render === 'function' - Remove redundant test for invalid render properties - Normalize test names to imperative style - Remove error handling test to let errors bubble up naturally The logic is now cleaner: - If render is not provided → checkbox - If render is provided and valid → use it - If render is provided but invalid → null (filtered out) * Fix layout * Add test coverage for CSS component * Imorove a11y and conveage * Add very basic sanitization of the value * Avoid custom CSS and use components for spacing * Revert all changes to styles Unlinked contributors: Membele, BiDbMAK, sarahmonster, prasadgupte, smerriman, kticka, leadclown, ScotsScripts, ekazda, svedish, frogdesk, michaelsoriano, Chillifish, DougMelvin, burnuser, mdmoreau, logiclink. Co-authored-by: getdave <[email protected]> Co-authored-by: mikachan <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: DamirPecnik <[email protected]> Co-authored-by: driviera <[email protected]> Co-authored-by: paaljoachim <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: glendaviesnz <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: karmatosed <[email protected]> Co-authored-by: nextgenthemes <[email protected]>
…2186) Co-authored-by: shimotmk <[email protected]> Co-authored-by: t-hamano <[email protected]>
Co-authored-by: oandregal <[email protected]> Co-authored-by: jorgefilipecosta <[email protected]>
* FIXED THE CHANGES AS ASKED * markdown updated Co-authored-by: sidharthpandita1 <[email protected]> Co-authored-by: hanneslsm <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: shimotmk <[email protected]>
* Add manual URL binding resolution to navigation blocks * Fix PHPCS formatting issues in navigation blocks - Fix alignment of equals signs in binding resolution code - All files now pass PHPCS standards Co-authored-by: getdave <[email protected]> Co-authored-by: scruffian <[email protected]>
…ordPress#72171) - Make handleEntities conditional on binding presence in LinkUI - Existing links with id but no binding remain editable - New links with id and binding get locked entity UI - Prevents regression for existing WordPress sites - Adds E2E test to verify fix Co-authored-by: getdave <[email protected]> Co-authored-by: scruffian <[email protected]>
Co-authored-by: talldan <[email protected]> Co-authored-by: getdave <[email protected]>
Co-authored-by: t-hamano <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: jasmussen <[email protected]>
…72206) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]>
Co-authored-by: karthick-murugan <[email protected]> Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: t-hamano <[email protected]> Co-authored-by: shimotmk <[email protected]> Co-authored-by: mikachan <[email protected]>
* Add fitText field to block.json schema Adds fitText block support definition to enable proper validation and autocomplete for the fitText feature added in WordPress#71904. Fixes WordPress#72190 * Move fitText to supports.typography.fitText location Addresses review feedback to place fitText under typography supports rather than as a top-level support property. Co-authored-by: aditya241104 <[email protected]> Co-authored-by: t-hamano <[email protected]>
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: mikachan <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: cr0ybot <[email protected]>
…ordPress#72115) * CheckboxControl, RadioControl: Ensure focus on click * Add changelog * Also fix in `ToggleControl` Co-authored-by: mirka <[email protected]> Co-authored-by: aduth <[email protected]> Co-authored-by: oandregal <[email protected]>
Co-authored-by: oandregal <[email protected]> Co-authored-by: Mamaduka <[email protected]>
…ress#72221) The attempt to keep track of caret position via applyRange was stealing focus back to the canvas when those changes were coming from an off-canvas input (navigation link block text changes from inspector sidebar input). In these cases, it's not an expected behavior to keep the selection location, as the text length is changing intentionally off canvas. In these cases, it's better to not keep track of that focus. Making `RichText`'s `applyFromProps()` `domOnly` if the `text.length` changes and if focus is outside the canvas prevents focus from being stolen from the sidebar.
…rdPress#71814) * Focus comments Input field * Feedback changes * Feedback changes * Feedback changes * Feedback changes * Implement utils functionality * Index file conflict issue * Js Lint issues * JS Linting issues * Removing focus changes * Style changes Co-authored-by: karthick-murugan <[email protected]> Co-authored-by: roseg43 <[email protected]> Co-authored-by: joedolson <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: jeffpaul <[email protected]>
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: t-hamano <[email protected]>
* Fix term description context * Fix error Co-authored-by: mikachan <[email protected]> Co-authored-by: ntsekouras <[email protected]>
…ress#72231) Co-authored-by: talldan <[email protected]> Co-authored-by: ramonjd <[email protected]>
Co-authored-by: youknowriad <[email protected]> Co-authored-by: talldan <[email protected]>
* Add initial block * Add tagName attribute * Fix phpcs * Update packages/block-library/src/term-name/block.json Co-authored-by: Aki Hamano <[email protected]> * Add border-box * Remove term from isLink render logic * Update HTML element selector * Switch to HeadingLevelDropdown * Remove border radius and margin controls * Use pseudo link * Allow block to be used outside of terms query * Remove apply_filters * Rename tagName to level * Add apply_filters back * Add new icon * Remove fill from svg * Add term title keyword * Remove experimental flag * Fix spacing * Remove apply_filters * Add test fixture * Add style import * Update svg --------- Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: mikachan <[email protected]> Co-authored-by: cr0ybot <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: kmanijak <[email protected]>
…ordPress#72556) Co-authored-by: talldan <[email protected]> Co-authored-by: Mamaduka <[email protected]>
…ttribute to script module (WordPress#72489) * Reuse wp_script_attributes filter for adding data-wp-router-options attribute to script module * Use wp_json_encode() * Make gutenberg_script_module_add_router_options_attributes() more concise * Improve phpdoc return tags * Remove compat/wordpress-6.9/script-modules.php * Update backport changelog * (WIP) Use render_block_data to filter all blocks co-authored: @samueljseay * Adjust manual registration of blocks in e2e tests * We should not need any manual registration now. * Update changelog to match new wordpress-develop PR. * Fix merge conflict mistake * Remove redundant white space change * Fix merge conflict mistake * Move conditional code to compat, check for existence of new method when re-registering existing core blocks * Fix typo in code comment. Co-authored-by: Luis Herranz <[email protected]> * Simplify the compatibility check. --------- Co-authored-by: westonruter <[email protected]> Co-authored-by: luisherranz <[email protected]> Co-authored-by: samueljseay <[email protected]> Co-authored-by: DAreRodz <[email protected]>
…ss#72476) Co-authored-by: ockham <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: cbravobernal <[email protected]>
* Add `theme` package Co-authored-by: ciampo <[email protected]> Co-authored-by: jsnajdr <[email protected]> * Remove ts extensions * Handle CSS modules * Update package lock * Allow public documentation * Add content to readme * Lock private APIs * Fix missing React error in test file Due to "moduleResolution": "bundler" tsconfig in this package * Remove test for now (requires jest 30) * Remove Storybook for now (punt to follow-up) * Remove build scripts to bin * Move to prebuild folder * Lint all prebuild files * Move `design-tokens.ts` file to prebuild folder * Fixup * Prebuild as part of root build process * Try resolving floating point differences * Update readme * Remove layers from stylesheet * Reduce color ramp tests * Move prebuild files into src (fixes types) * Allow theme package to participate in private APIs * Output combined stylesheet * Rename prebuild to prebuilt --------- Co-authored-by: ciampo <[email protected]> Co-authored-by: jsnajdr <[email protected]> Co-authored-by: mirka <[email protected]>
…ordPress#72533) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: t-hamano <[email protected]>
* iAPI: Update deprecated usage of data-wp-on-async in core blocks * WIP Co-authored-by: t-hamano <[email protected]> Co-authored-by: DAreRodz <[email protected]>
…ordPress#72289) * Fix Classic Menu to Navigation Link conversion with entity bindings - Add buildNavigationLinkEntityBinding function to menu-items-to-blocks.js - Update menuItemToBlockAttributes to include entity bindings for non-custom items - Add comprehensive test coverage for entity binding behavior - Ensure classic menu conversions maintain dynamic URL resolution - Follow same pattern as PR WordPress#72287 for consistency Fixes classic menu items losing entity relationships during conversion. * Use canonical building of bindings * Update test expectations * Add edge case coverage for unsupported kinds Co-authored-by: getdave <[email protected]> Co-authored-by: scruffian <[email protected]>
…#72573) Co-authored-by: t-hamano <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: Mamaduka <[email protected]>
* Notes: Backport REST API changes in core * Rename class name * Correctly load controller --------- Co-authored-by: t-hamano <[email protected]> Co-authored-by: Mamaduka <[email protected]>
The Date block now defaults to allowing the user to setting a custom date. (The previous default behavior — showing the publish date of the containing post — was turned into a block variation). Co-authored-by: ockham <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: ntsekouras <[email protected]>
Co-authored-by: stokesman <[email protected]> Co-authored-by: t-hamano <[email protected]>
* Fix build command for tokens package on Windows * Avoid glob patterns altogether Co-authored-by: aduth <[email protected]> Co-authored-by: dream-encode <[email protected]>
* Fix confusion between clientId and rootClientId * Fix contentOnly insertion logic for blocks at root of section * Fix movers appearing in contentOnly mode * Rename selector that mentions write mode * Fix typo * Add e2e tests for synced patterns to ensure blocks cannot be moved duplicate or deleted * Update move behavior to disable movers for templateLock contentOnly * Add contentOnly templateLock tests for block duplication, insertion and moving * Add buttons example to pattern overrides test too * Fix selector memoization * Make the selectors work in a more similar fashion * Fix test * Allow moving for template lock of `insert` * Make home link a content block * Condense identical test cases ---- Co-authored-by: talldan <[email protected]> Co-authored-by: tellthemachines <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: scruffian <[email protected]>
Co-authored-by: mikachan <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: cr0ybot <[email protected]>
…ordPress#72496) Co-authored-by: jeryj <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: ellatrix <[email protected]>
…t is the last one. (WordPress#72606) Co-authored-by: roseg43 <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: jasmussen <[email protected]>
Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: oandregal <[email protected]> Co-authored-by: jameskoster <[email protected]>
Co-authored-by: jameskoster <[email protected]> Co-authored-by: oandregal <[email protected]> Co-authored-by: dinhtungdu <[email protected]>
…ress#72570) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: mcsf <[email protected]>
…s#72303) * fit text issue * Changes made * Changes made as asked * Update packages/block-editor/src/hooks/fit-text.js --------- Co-authored-by: sidharthpandita1 <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: jasmussen <[email protected]>
…ss#72618) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]>
Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: simison <[email protected]> Co-authored-by: hanneslsm <[email protected]>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @gutenbergplugin. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +9.95 kB (+0.45%) Total Size: 2.2 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast