feat(core): Implement new traits on 'old' Graphs#944
Open
RaoulLuque wants to merge 10 commits intomasterfrom
Open
feat(core): Implement new traits on 'old' Graphs#944RaoulLuque wants to merge 10 commits intomasterfrom
RaoulLuque wants to merge 10 commits intomasterfrom
Conversation
… an entire module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the new traits introduced in #927 for the old graphs, that is the so far existing graphs in
petgraph. This is done by addingpetgraph 0.8as a dependency and implementing the traits for the graphs imported from this version.More specifically, this PR depends on the PR #946 for the
0.8branch, as this PR exposes some functionality for the old graphs (in particularMatrixGraph) which is necessary to implement the new traits on the old graphs. Said PR is planned to be merged and put out in the release0.8.4.ofpetgraph.