Conversation
Contributor
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
starovoid
reviewed
Dec 3, 2025
Collaborator
There was a problem hiding this comment.
Hi, glad to see this PR! I only suggest renaming
GSI --> Gsi
GSISMall --> GsiSmall
in serialization-tests/tests/serialization.rs / from_json_digraph_str_i32 function.
to satisfy just ci runs.
(Or add a skip of the appropriate lint)
RaoulLuque
reviewed
Dec 3, 2025
Co-authored-by: Raoul Luqué <[email protected]>
…nto bm/init-crate-layout
RaoulLuque
force-pushed
the
bm/init-crate-layout
branch
from
802bd7d to
e775168
Compare
Member
|
Accidentally pushed to your branch, sry ^^ |
Member
|
Note that I cancelled the Unsoundness check fast, as it seems to be running for ~4 hours for some reason. #924 fixes this (by temporarily disabling the job). So be careful when pushing new changes without the fix 👍 |
Closed
This was referenced Dec 9, 2025
Open
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates the necessary crate layout.
Additionally does:
BREAKING CHANGE: Initialize pegraph-core