ci: Fix Hashbrown dependencies#878
Merged
RaoulLuque merged 4 commits intopetgraph:masterfrom Sep 21, 2025
Merged
Conversation
RaoulLuque
added
A-ci
starovoid
approved these changes
Sep 21, 2025
Collaborator
starovoid
left a comment
starovoid
left a comment
There was a problem hiding this comment.
I like it as a temporary fix, but apparently it's already worth raising the MSRV in the next breaking release.
notxvilka
approved these changes
Sep 21, 2025
Member
Author
I am not sure I properly understand your wording. What do you mean exactly? Technically I think it is not necessary to raise the MSRV in the next breaking release, as petgraph works with 1.64. On that note, I just tried creating a new project with cargo, adding indexmap as a dependency and that failed, so I'll head there and see whether that's maybe an issue on their side 👍 |
This was referenced Sep 21, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 28, 2025
As suggested in indexmap-rs/indexmap#419 (comment), this edits the CI action such that when it is run with the MSRV, Cargo resolves the dependencies for that use case first, such that compatible dependency versions should be locked in cargo.lock. This is a follow-up and more permanent fix to the temporary fix from #878.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be an issue with different versions of Hashbrown dependencies:
(PR Job)
The version pinning was put in place because Rust 1.64 is actually only compatible with Hashbrown 0.15.0 and not 0.15.5 (the above error stems from the Rust 1.64 Test Job - see link).
This PR now pins both Hashbrown versions (ours should be 0.15.5) to 0.15.0.
Hashbrown 0.16 should be another dependency pulled in due to indexmap, see this excerpt from
Cargo.lock:Probably due to some other change (possibly in Cargo?), the default version for the indexmap dependency changed from 0.15.5 to 0.16 which now induces the ambiguity error from above. The specified dependency in indexmap is:
So both 0.15.5 and 0.16 would be valid.