ci: Use the pr's branch on semver-checks pull_request_target workflow#694
Merged
ci: Use the pr's branch on semver-checks pull_request_target workflow#694
pull_request_target workflow#694Conversation
ABorgna
force-pushed
the
ab/semver-checks-fix-ref
branch
from
9bd63e6 to
f652bca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
semver-checksworkflow from #692 usespull_request_targetas a workflow trigger.When using
_targetinstead ofpull_requestevents,actions/checkoutfetches the base branch of the PR by default.See in this workflow, both the base and "head" checkouts use the same sha.
https://github.com/petgraph/petgraph/actions/runs/12163228521/job/33921923785?pr=675#step:2:72
This fix sets an explicit parameter when fetching the head.
drive-by: Check if the PR has build errors and skip posting comments if so.