add dependency list for feature 'quickcheck'#372
Closed
JOE1994 wants to merge 2 commits intopetgraph:masterfrom
JOE1994:apply_quickcheck
Closed
add dependency list for feature 'quickcheck'#372JOE1994 wants to merge 2 commits intopetgraph:masterfrom JOE1994:apply_quickcheck
JOE1994 wants to merge 2 commits intopetgraph:masterfrom
JOE1994:apply_quickcheck
Conversation
This change is made to avoid name conflicts when defining dependencies (library name vs. feature gate name).
Member
|
Nice catch! Not sure about the name though. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
Currently it seems to be impossible to run the following test setup due to missing dependency declarations: ``` cargo test --no-default-features --features 'quickcheck' ``` This was first observed in #331. Running the above fails due to multiple reasons which boil down to other features being disabled which are actually necessary. This PR aims to fix that by declaring a dependency list for the quickcheck feature and is a revamp of #372. Thus, this resolves #331. I am not 100% certain about the `std` dependency in the quickcheck dependency list, but without that dependency there seem to be some issues with missing RandomStates (std) to initialize certain structs in quickchecks. Since furthermore Quickcheck does not have `no-std`, it would - according to my understanding - include std anyways.
RaoulLuque
added a commit
to RaoulLuque/petgraph
that referenced
this pull request
Jun 18, 2025
Currently it seems to be impossible to run the following test setup due to missing dependency declarations: ``` cargo test --no-default-features --features 'quickcheck' ``` This was first observed in petgraph#331. Running the above fails due to multiple reasons which boil down to other features being disabled which are actually necessary. This PR aims to fix that by declaring a dependency list for the quickcheck feature and is a revamp of petgraph#372. Thus, this resolves petgraph#331. I am not 100% certain about the `std` dependency in the quickcheck dependency list, but without that dependency there seem to be some issues with missing RandomStates (std) to initialize certain structs in quickchecks. Since furthermore Quickcheck does not have `no-std`, it would - according to my understanding - include std anyways.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 🦀 , this PR attempts to fix issue #331 (resolves #331).
Currently running
cargo test --no-default-features --features 'quickcheckfails with errors.This PR makes the following changes to solve the issue.
quickcheckquickchecktoapply_quickcheckThe reason for this changes is that the project currently has a name conflict between the feature
quickcheckand the dependency library namequickcheck. Featurequickcheckisn't defined inCargo.toml, but is used for a feature gate insrc/lib.rs. I had to resolve the name conflict to enable adding a dependency list for featurequickcheck.Thank you for reviewing this PR 👍