-
Notifications
You must be signed in to change notification settings - Fork 441
Open
Labels
A-crateArea: Petgraph crate functionalityArea: Petgraph crate functionalityC-feature-acceptedCategory: A feature request that has been accepted pending implementationCategory: A feature request that has been accepted pending implementationC-refactorCategory: PR/issue with specific code/suggestions for refactoringCategory: PR/issue with specific code/suggestions for refactoringS-breaking-changeStatus: Need a breaking change release to progressStatus: Need a breaking change release to progress
Milestone
Description
Abstract
I suggest to rewrite the implementation of 'Csr' by using Option & Error in the API and internal methods.
Currently, most of the Csr methods are prone to panic in case of any errors in the arguments passed. Moreover, it is impossible to add checked counterparts of existing methods without significant code duplication. So it's easier to make breaking changes in one of the further major releases, moving away from panic to Error and Option in the entire Csr API.
Discussion
Perhaps such major changes should be implemented after the adoption of the Storage API changes #563
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-crateArea: Petgraph crate functionalityArea: Petgraph crate functionalityC-feature-acceptedCategory: A feature request that has been accepted pending implementationCategory: A feature request that has been accepted pending implementationC-refactorCategory: PR/issue with specific code/suggestions for refactoringCategory: PR/issue with specific code/suggestions for refactoringS-breaking-changeStatus: Need a breaking change release to progressStatus: Need a breaking change release to progress