Added no_std feature switch.#31
Merged
jrraymond merged 3 commits intopetgraph:masterfrom Aug 25, 2019
Merged
Conversation
Types from core module are used instead of std when no_std feature is enabled. This also enables alloc feature and uses alloc crate. Removed println statements from tests since they don't work in no_std.
Contributor
Author
|
@bluss what do you think? |
Contributor
Author
|
@bluss have you had chance to review the changes? Any comments would be appreciated. |
|
@bluss Can we look into merging this? The changes seem minimal & the new feature unblocks this issue |
jrraymond
approved these changes
Aug 25, 2019
Member
|
Using a "positive" feature flag for "no_std" is not how this is usually done, because features must be additive. I'll have to half revert this back to the solution that works well with cargo features. Using a feature "std" that is a default feature is the normal solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types from core module are used instead of std when no_std feature is
enabled. This also enables alloc feature and uses alloc crate. Removed
println statements from tests since they don't work in no_std.