implement intersection and union#20
Conversation
|
Oh my thanks, this crate, that I've almost forgot about. Maybe you're interested in being co-maintainer? This looks good. What do you think about this in relation to additional in-place union/intersection operations? (Those can be added later, as other method names?) Since HashSet has bit ops for these operations, we have precedent for that too. But in fixedbitset we keep things rather simple if we can.. |
|
I would be interested in being a co-maintainer. The I think we should mirror hashset exactly. Consistent interfaces make development so much easier for users. I will update the PR rename the current |
|
I agree with following conventions yet I wouldn't want to change the existing methods in the FixedBitSet, they are sort of tailor made for the bit set and don't all match (Most visibly probably the insert method?) |
|
I'd be happy to add you as co maintainer |
|
Yes, I agree we shouldn't break backwards compatibility, but for the new methods in this PR (union&intersection) I think it is probably better to be consistent with |
|
Yes that sounds good. To critique HashSet, I don't agree with not having method names for their HashSet-returning union operation (but it makes naming easier if we don't need to invent new names for similar operations..) |
|
Its really hard to come up with a name for |
|
This reminds me, we should probably implement |
|
Thanks for this, I'll make a release |
No description provided.