Fix Windows 7 Builds#17
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues with Windows 7 builds by pinning the Rust toolchain to version 1.75.0 and making necessary adjustments in configuration and CI workflows.
- Introduces a separate Cargo-win7.lock file for Windows 7 uses
- Removes unneeded dependencies in Cargo.toml
- Updates GitHub Actions workflows to support static linking for Windows
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Adds instructions for Windows 7 support using Rust 1.75.0 |
| Cargo.toml | Removes unneeded dependencies and sets Windows-specific rustflags |
| .github/workflows/test-release.yml | Replaces manual build/archive steps with an action, adding static linking via env variables |
| .github/workflows/release.yml | Implements a setup step for Windows 7 lockfile and pins the Rust toolchain version |
Comments suppressed due to low confidence (2)
.github/workflows/test-release.yml:46
- Consider adding a comment to clarify the purpose of the 'dry-run: true' flag in this step, which will help future maintainers understand its intended usage.
dry-run: true
Cargo.toml:20
- If the dependency 'term' is removed as unneeded, consider documenting the rationale for its removal to ensure that its exclusion doesn't affect existing functionality.
-term = "1.0.2"
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer Rust tooling appears to be broken for Windows 7. This appears to have been an intentional deprecation.
As it'll be hard to come up with a maintainable build for this app using newer Rust version, I've pinned Windows builds to use the older Rust 1.75.0.
Fixes #16
Thanks a lot for filing this @sergeevabc, sorry for the delay! You can grab some binaries to test out from this test run (see Artifacts section at the bottom): https://github.com/peteretelej/tree/actions/runs/15509101323
This may work for other projects facing the same issue but will depend on if dependencies they use need a newer Rust or not.