Compact dropdown: cap the native menu short (v0.4.7)#13
Merged
Conversation
The native menu grows to its content height and only scrolls once it exceeds the whole screen, so a long history filled the display. Cap the dropdown to a compact panel instead: hard ceiling 100 -> 20 (re-clamps existing high "Show in dropdown" settings down on upgrade, so the menu shrinks with no action from the user), default 25 -> 10, presets 10/25/50/100 -> 5/10/15/20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The dropdown is a native
NSMenu, which grows to its content height and only starts scrolling once it exceeds the whole screen - so a long clipboard history filled the display. There's no API to cap a native menu at a fixed sub-screen height with internal scroll, so the lightweight fix is to show fewer entries.How
MAX_MENU_ITEMS_HARD100 → 20 - re-clamps any higher saved "Show in dropdown" value down on upgrade, so existing installs shrink with no settings change.DEFAULT_DROPDOWN_ITEMS25 → 10.Result: the dropdown is a compact ~half-screen panel instead of a full-height wall of entries. Bumps the workspace to 0.4.7.