docs(README): clarify that an existing open PR is managed#3498
Merged
peter-evans merged 2 commits intopeter-evans:mainfrom Nov 26, 2024
Merged
docs(README): clarify that an existing open PR is managed#3498peter-evans merged 2 commits intopeter-evans:mainfrom
peter-evans merged 2 commits intopeter-evans:mainfrom
Conversation
peter-evans
reviewed
Nov 26, 2024
Owner
peter-evans
left a comment
peter-evans
left a comment
There was a problem hiding this comment.
Thanks for raising this and trying to make the readme clearer!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was confused by the README, because it mentioned updating an existing branch, but not updating an existing pull request. Obviously, it doesn't make sense for the action to create a new PR even if there is an existing open PR, but I figure it's better to be explicit upfront in the README.