|
| 1 | +"""Tests for pete_mcp_core.session_reaper.""" |
| 2 | + |
| 3 | +from __future__ import annotations |
| 4 | + |
| 5 | +import logging |
| 6 | + |
| 7 | +import pytest |
| 8 | +from mcp.server.streamable_http_manager import StreamableHTTPSessionManager |
| 9 | + |
| 10 | +from pete_mcp_core.session_reaper import ( |
| 11 | + DEFAULT_IDLE_TIMEOUT, |
| 12 | + _resolve_timeout, |
| 13 | + enable_session_reaper, |
| 14 | +) |
| 15 | + |
| 16 | + |
| 17 | +@pytest.fixture(autouse=True) |
| 18 | +def _clear_env(monkeypatch: pytest.MonkeyPatch) -> None: |
| 19 | + monkeypatch.delenv("MCP_SESSION_IDLE_TIMEOUT", raising=False) |
| 20 | + |
| 21 | + |
| 22 | +class TestResolveTimeout: |
| 23 | + def test_defaults_when_env_missing(self) -> None: |
| 24 | + assert _resolve_timeout(None) == DEFAULT_IDLE_TIMEOUT |
| 25 | + |
| 26 | + def test_explicit_wins_over_env(self, monkeypatch: pytest.MonkeyPatch) -> None: |
| 27 | + monkeypatch.setenv("MCP_SESSION_IDLE_TIMEOUT", "900") |
| 28 | + assert _resolve_timeout(60.0) == 60.0 |
| 29 | + |
| 30 | + def test_reads_env(self, monkeypatch: pytest.MonkeyPatch) -> None: |
| 31 | + monkeypatch.setenv("MCP_SESSION_IDLE_TIMEOUT", "900") |
| 32 | + assert _resolve_timeout(None) == 900.0 |
| 33 | + |
| 34 | + @pytest.mark.parametrize("value", ["off", "0", "none", "false", "DISABLED"]) |
| 35 | + def test_disable_values(self, monkeypatch: pytest.MonkeyPatch, value: str) -> None: |
| 36 | + monkeypatch.setenv("MCP_SESSION_IDLE_TIMEOUT", value) |
| 37 | + assert _resolve_timeout(None) is None |
| 38 | + |
| 39 | + def test_blank_env_falls_back_to_default(self, monkeypatch: pytest.MonkeyPatch) -> None: |
| 40 | + monkeypatch.setenv("MCP_SESSION_IDLE_TIMEOUT", " ") |
| 41 | + assert _resolve_timeout(None) == DEFAULT_IDLE_TIMEOUT |
| 42 | + |
| 43 | + def test_rejects_garbage(self, monkeypatch: pytest.MonkeyPatch) -> None: |
| 44 | + monkeypatch.setenv("MCP_SESSION_IDLE_TIMEOUT", "half an hour") |
| 45 | + with pytest.raises(ValueError, match="MCP_SESSION_IDLE_TIMEOUT"): |
| 46 | + _resolve_timeout(None) |
| 47 | + |
| 48 | + def test_negative_explicit_disables(self) -> None: |
| 49 | + assert _resolve_timeout(-1.0) is None |
| 50 | + |
| 51 | + |
| 52 | +class TestEnableSessionReaper: |
| 53 | + def test_sdk_supports_the_parameter(self) -> None: |
| 54 | + """Positive control: if this fails the workaround is moot, not broken.""" |
| 55 | + import inspect |
| 56 | + |
| 57 | + params = inspect.signature(StreamableHTTPSessionManager.__init__).parameters |
| 58 | + assert "session_idle_timeout" in params |
| 59 | + |
| 60 | + def test_injects_default_timeout(self) -> None: |
| 61 | + enable_session_reaper() |
| 62 | + manager = StreamableHTTPSessionManager(app=object()) |
| 63 | + assert manager.session_idle_timeout == DEFAULT_IDLE_TIMEOUT |
| 64 | + |
| 65 | + def test_unpatched_manager_has_no_timeout(self) -> None: |
| 66 | + """Negative control: without the patch the SDK default really is None.""" |
| 67 | + manager = StreamableHTTPSessionManager(app=object()) |
| 68 | + assert manager.session_idle_timeout is None |
| 69 | + |
| 70 | + def test_explicit_timeout_wins(self) -> None: |
| 71 | + enable_session_reaper(60.0) |
| 72 | + manager = StreamableHTTPSessionManager(app=object()) |
| 73 | + assert manager.session_idle_timeout == 60.0 |
| 74 | + |
| 75 | + def test_never_overrides_an_explicit_caller(self) -> None: |
| 76 | + enable_session_reaper() |
| 77 | + manager = StreamableHTTPSessionManager(app=object(), session_idle_timeout=30.0) |
| 78 | + assert manager.session_idle_timeout == 30.0 |
| 79 | + |
| 80 | + def test_skips_stateless_mode(self) -> None: |
| 81 | + """The SDK raises if a stateless manager is handed an idle timeout.""" |
| 82 | + enable_session_reaper() |
| 83 | + manager = StreamableHTTPSessionManager(app=object(), stateless=True) |
| 84 | + assert manager.session_idle_timeout is None |
| 85 | + |
| 86 | + def test_skips_stateless_passed_positionally(self) -> None: |
| 87 | + enable_session_reaper() |
| 88 | + manager = StreamableHTTPSessionManager(object(), None, False, True) |
| 89 | + assert manager.session_idle_timeout is None |
| 90 | + |
| 91 | + def test_disabled_leaves_sdk_default(self, monkeypatch: pytest.MonkeyPatch) -> None: |
| 92 | + monkeypatch.setenv("MCP_SESSION_IDLE_TIMEOUT", "off") |
| 93 | + assert enable_session_reaper() is None |
| 94 | + manager = StreamableHTTPSessionManager(app=object()) |
| 95 | + assert manager.session_idle_timeout is None |
| 96 | + |
| 97 | + def test_is_idempotent(self) -> None: |
| 98 | + enable_session_reaper(120.0) |
| 99 | + first = StreamableHTTPSessionManager.__init__ |
| 100 | + assert enable_session_reaper(999.0) == 999.0 |
| 101 | + assert StreamableHTTPSessionManager.__init__ is first |
| 102 | + manager = StreamableHTTPSessionManager(app=object()) |
| 103 | + assert manager.session_idle_timeout == 120.0 |
| 104 | + |
| 105 | + def test_logs_the_installed_timeout(self, caplog: pytest.LogCaptureFixture) -> None: |
| 106 | + with caplog.at_level(logging.INFO, logger="pete_mcp_core.session_reaper"): |
| 107 | + enable_session_reaper(300.0) |
| 108 | + assert any("Session idle reaper enabled" in r.getMessage() for r in caplog.records) |
| 109 | + |
| 110 | + def test_warns_when_sdk_lacks_support( |
| 111 | + self, monkeypatch: pytest.MonkeyPatch, caplog: pytest.LogCaptureFixture |
| 112 | + ) -> None: |
| 113 | + def legacy_init(self, app, event_store=None, json_response=False, stateless=False): |
| 114 | + self.session_idle_timeout = None |
| 115 | + |
| 116 | + monkeypatch.setattr(StreamableHTTPSessionManager, "__init__", legacy_init) |
| 117 | + with caplog.at_level(logging.WARNING, logger="pete_mcp_core.session_reaper"): |
| 118 | + assert enable_session_reaper() is None |
| 119 | + assert any("does not accept session_idle_timeout" in r.getMessage() for r in caplog.records) |
0 commit comments