Repository navigation
Conversation
Replace the Effect.orDie on realPath of the source worktree with a Snapshot.Error. capture() already logs and returns undefined on failure, so a worktree removed after discovery no longer escapes as a defect.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes anomalyco#50548
Type of change
What does this PR do?
Snapshotresolves the source worktree withfs.realPath(source.worktree).pipe(Effect.orDie). If that directory is removed after Git discovery, theNotFounderror becomes a defect.capture()only catches failures, so the defect escapes it and crashes the snapshot fiber instead of degrading.This PR maps that error to
Snapshot.Errorwith the samefailure("capture", ...)helper the next line of the effect already uses:capture()logs a warning and returnsundefined, the same as its other failures, so snapshots are reported as unavailable.files,diff, andrestorereturn a typedSnapshot.Errorinstead of a defect.This only covers the snapshot service. It does not fix the saved dead project path in the desktop client, which is tracked in anomalyco#50137.
How did you verify your code works?
bun test test/snapshot.test.tsinpackages/core: 12 pass, 0 fail.realPathto fail withNotFound. With the oldorDieit fails because the defect escapescapture(). With this change it passes.bun typecheckinpackages/core: clean.bun run checkfrom the repo root.Screenshots / recordings
N/A, not a UI change.
Checklist