Skip to content

Conversation

@glensc
Copy link
Contributor

@glensc glensc commented Mar 30, 2025

This will hopefully fix dependabot errors
@glensc glensc self-assigned this Mar 30, 2025
@rfay
Copy link

rfay commented Mar 30, 2025

Awesome! Is it worth considering 8.4?

@glensc
Copy link
Contributor Author

glensc commented Mar 30, 2025

Awesome! Is it worth considering 8.4?

latest alpine doesn't have it, so it would require custom build. so not worth of it. if you mean version in docker image. general support should be added anyway to be compatible

@glensc glensc merged commit f1c4450 into 0.23.x Mar 30, 2025
5 checks passed
@glensc glensc deleted the php-8 branch March 30, 2025 13:33
XHGui has the following requirements:

- Known to work: PHP >= 7.2, 8.0, 8.1
- Known to work: PHP >= 7.2, 8.0-8.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer.json now requires php > 8.0
Should we remove the mention of PHP 7.2?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also removed the test for PHP 7.2/7.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glensc glensc added this to the 0.23.2 milestone Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants