Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How not to use the bell #48

Closed
shossk opened this issue May 15, 2021 · 6 comments · Fixed by #61
Closed

How not to use the bell #48

shossk opened this issue May 15, 2021 · 6 comments · Fixed by #61
Labels
enhancement New feature or request

Comments

@shossk
Copy link

shossk commented May 15, 2021

Hi @rwngallego

This plugin is awesome! But what if I want to show alerts directly on all pages without using the bell?

I also looked at perfecty-push-js-sdk, but it looks like I need to change the Plugin after all, so please let me know.

Sorry for the text in translation.

@rwngallego
Copy link
Collaborator

Hello, you can hide it using the "Hide bell after subscribing" option in Perfecty Push > Settings > Public widget. You cannot send push messages if the user has not subscribed (this is part of how Push Notifications work and doesn't depend on our plugin) so it's mandatory to show them the bell so that they can subscribe. Once they subscribe, the bell will disappear.

@shossk
Copy link
Author

shossk commented May 16, 2021

Thank you. I'm sorry, but I'm not sure what I wrote.
Right now I have to click on the bell to get the dialog to allow notifications, but I'd like that to show up directly.
I know I can hide the bell icon, but that doesn't bring up the dialog.
I'd love to be able to change the hierarchy of where the dialog appears in the settings.
I think I can add that to window.PerfectyPushOptions.

Thanks!

@rwngallego
Copy link
Collaborator

Right now we don't support asking notifications directly, you can follow this previous conversation:

The reasons to not do it are very well explained here: https://developers.google.com/web/fundamentals/push-notifications/permission-ux

It’s considered a bad practice to ask for browser permissions directly. For the moment, the plugin doesn’t support other patterns but we have plans to do it, and if there are good reasons to support direct permissions, we could consider them. Could you please elaborate your use case?

@shossk
Copy link
Author

shossk commented May 23, 2021

I don't have a specific use case, but in Japan, where I am from, there are many sites that display it directly, and I recognize that it is probably a national trait.
Therefore, my client instructed me to create something similar to that.
I'm sorry I can't provide a specific use case.
I just don't think I can do away with the direct display on all pages.
I also recognize that direct display is a bad thing, so I've decided to make a special exception and use the forked version for this case.
Thank you for your patience on this matter. But the plugin itself is very nice!
I'd be happy to help with the translation next time I have time!
I'm closing this case now, thank you for your support!

@shossk shossk closed this as completed May 23, 2021
@rwngallego
Copy link
Collaborator

Hi @shossk thanks for letting us know. As I said, we've received this request in the past so we might support it. I'll keep it as open so that we can address this in the upcoming versions.

@rwngallego
Copy link
Collaborator

This has been released in v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants