Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that the wp-crons are enabled #33

Closed
rwngallego opened this issue Apr 23, 2021 · 4 comments · Fixed by #60
Closed

Check that the wp-crons are enabled #33

rwngallego opened this issue Apr 23, 2021 · 4 comments · Fixed by #60
Labels
enhancement New feature or request

Comments

@rwngallego
Copy link
Collaborator

Make sure that the plugin warns if the wp-crons are disabled. Usually they're disabled like this: https://zeropointdevelopment.com/disabling-wp-cron-in-wordpress/#:~:text=To%20disable%20WP%2DCron%20in,up%20from%20your%20local%20machine.

If they're disabled, the plugin cannot execute the background jobs.
@rwngallego rwngallego added the enhancement New feature or request label Apr 23, 2021
@MocioF
Copy link
Contributor

MocioF commented Jun 2, 2021

Hi @rwngallego I could work on this. The idea is to create a "fake" scheduled action recording its execution time somewhere, just to see if it is executed and when, so in this way we can monitor if a cron (wp-cron or system cron) is "running".
Can I go this way, or were you thinking about just a check on DISABLE_WP_CRON ?

@rwngallego
Copy link
Collaborator Author

Hi @MocioF, that would be awesome! :) I was thinking in either any of those two options. Let's go first with the bare minimum and if necessary we could extend it later. So let's do it with the DISABLE_WP_CRON flag first.

@MocioF
Copy link
Contributor

MocioF commented Jun 4, 2021

Hi, @rwngallego I worked on this.
I added a box in the dashboard to show log check, and an admin alert when it seems a cron is not in place.
If you don't like it (the monitor, the checks, or others), please let me know.
I added an admin notice when cron seems not to work (the code is set to make a check every 30 minutes), but I am not sure that showing it on every admin page is a good choice.
Let me know what you think. I will send a PR in minutes.

admin_alert
monitor_says_cron_works
monitor_says_cron_is_stopped

@MocioF MocioF mentioned this issue Jun 4, 2021
Merged
@rwngallego rwngallego mentioned this issue Jun 13, 2021
Merged
@rwngallego
Copy link
Collaborator Author

This has been released in v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dependency on logs, and execute only from the admin area. perfectyorg/perfecty-push-wp
2 participants
@rwngallego @MocioF