Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative numbers in failed notifications #102

Closed
matteomorreale opened this issue Aug 31, 2021 · 7 comments · Fixed by #105
Closed

Negative numbers in failed notifications #102

matteomorreale opened this issue Aug 31, 2021 · 7 comments · Fixed by #105
Labels
enhancement New feature or request

Comments

@matteomorreale
Copy link

Hi, the graph with the notifications recap has an issue related to failed notifications.
As you can see here
https://www.awesomescreenshot.com/image/12722763?key=aad4e489f1c578578798153d370a74b5
the few days old failed notifications are in a negative number and I really don't know why.
@rwngallego
Copy link
Collaborator

Hi @matteomorreale yes, it looks a bit weird. Could you please check if some notifications failed totally in any of those dates that have negative numbers? Thank you!

@rwngallego rwngallego added the question Further information is requested label Aug 31, 2021
@matteomorreale
Copy link
Author

I cannot find negative numbers elsewhere, but maybe it's related to the old subscribers with OneSignal?

@rwngallego
Copy link
Collaborator

No, not negative numbers. I want to confirm if maybe some of the notification jobs you sent in August 25 failed, and how many in total for that day. This will help us in understanding what the issue was, thank you!

@matteomorreale
Copy link
Author

Almost 200 notifications failed for every push sent in August 25, with 9 pushs in total

@rwngallego
Copy link
Collaborator

We will change the way in which we count the failed notifications. This will probably impact the reports but will be more reliable. Adding it to the backlog.

@rwngallego rwngallego added enhancement New feature or request and removed question Further information is requested labels Sep 3, 2021
@rwngallego rwngallego linked a pull request Sep 5, 2021 that will close this issue
Adjustments to the job management section #105
Merged
@rwngallego
Copy link
Collaborator

This will be released in v1.4.1

@rwngallego
Copy link
Collaborator

This has been included in v1.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjustments to the job management section perfectyorg/perfecty-push-wp
2 participants
@rwngallego @matteomorreale