Skip to content

feat: improve PageSelect#973

Merged
perber merged 1 commit into
mainfrom
feature/improve-page-selection
May 9, 2026
Merged

feat: improve PageSelect#973
perber merged 1 commit into
mainfrom
feature/improve-page-selection

Conversation

@perber

@perber perber commented May 9, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings May 9, 2026 13:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces the existing PageSelect dropdown with a searchable, keyboard-navigable list UI (used for choosing a new parent when moving pages/sections).

Changes:

  • Reimplemented PageSelect as a search input + scrollable result list with arrow-key navigation and Enter-to-select.
  • Added a new autoFocus prop to PageSelect.
  • Updated MovePageDialog to autofocus the PageSelect input.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
ui/leafwiki-ui/src/features/page/PageSelect.tsx Replaces the Select-based UI with a searchable list, adds keyboard navigation, and supports autoFocus.
ui/leafwiki-ui/src/features/page/MovePageDialog.tsx Passes autoFocus to the updated PageSelect in the move dialog.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ui/leafwiki-ui/src/features/page/PageSelect.tsx
Comment thread ui/leafwiki-ui/src/features/page/PageSelect.tsx Outdated
Comment thread ui/leafwiki-ui/src/features/page/PageSelect.tsx Outdated
Comment thread ui/leafwiki-ui/src/features/page/MovePageDialog.tsx
Comment thread ui/leafwiki-ui/src/features/page/PageSelect.tsx Outdated
@perber
perber force-pushed the feature/improve-page-selection branch from a3dd9a7 to 5ab7d53 Compare May 9, 2026 13:54
@perber
perber merged commit ca0eefa into main May 9, 2026
6 checks passed
@perber
perber deleted the feature/improve-page-selection branch May 9, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants